Skip to content

fix(theming): Add adjusted color versions of default background - #42424

Merged
susnux merged 1 commit into
masterfrom
fix/background-image
Dec 21, 2023
Merged

fix(theming): Add adjusted color versions of default background#42424
susnux merged 1 commit into
masterfrom
fix/background-image

Conversation

@susnux

@susnuxsusnux commented Dec 21, 2023

Copy link
Copy Markdown
Contributor

Summary

The color was adjusted by @jancborchardt for better / required contrast of the app menu

Checklist

…etter app-menu contrast
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@ShGKme

Copy link
Copy Markdown
Contributor

I wonder if we should change attribution here, as it is not an original image anymore.

'kamil-porembinski-clouds.jpg' => [
'attribution' => 'Clouds (Kamil Porembiński, CC BY-SA)',
'description' => 'Background picture of white clouds on in front of a blue sky',
'attribution_url' => 'https://www.flickr.com/photos/paszczak000/8715851521/',
'primary_color' => self::DEFAULT_COLOR,
],

@blizzzblizzz mentioned this pull request Mar 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BITV]: Replace default background image with darker one to pass a11y contrasts on menu

3 participants

@susnux@ShGKme@emoral435