Uh oh!
There was an error while loading. Please reload this page.
fix(theming): adjust default --color-background-plain to new background - #42456
Closed
ShGKme wants to merge 1 commit into
Closed
fix(theming): adjust default --color-background-plain to new background#42456ShGKme wants to merge 1 commit into
--color-background-plain to new background#42456ShGKme wants to merge 1 commit into
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
requested review from
jancborchardt, marcoambrosini, nimishavijay, skjnldsv and susnuxDecember 22, 2023 13:02
ShGKme
commented
Dec 22, 2023
ContributorAuthor
Tests are related, theming services should be adjusted |
ShGKme
marked this pull request as draft
December 22, 2023 15:01
jancborchardt
approved these changes
Dec 27, 2023
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Nice :) Is the color-background-plain needed anyway btw or is it now always color-primary-element?
skjnldsv
approved these changes
Dec 27, 2023
skjnldsv
commented
Dec 27, 2023
Member
You'll need to adjust testing |
marcoambrosini
approved these changes
Dec 28, 2023
7 tasks
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
susnux
commented
Jul 9, 2024
Contributor
|
ShGKme
commented
Jul 15, 2024
ContributorAuthor
Was fixed another way. |
skjnldsv
deleted the
fix/adjust-default-color-background-plain-to-new-background
branch
December 19, 2024 18:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
--color-background-plainwas the same as the default background image color. Now the image has changed.It is noticeable on slow connection.
On the image for me color is
#01679dwhile we use as primary#00679e, but 1/256 is not notable.Probably there are more places that we need to adjust.
Screenshots
Checklist