Skip to content

Remove disputed bz2 check - #42821

Merged
come-nc merged 1 commit into
nextcloud:masterfrom
J0WI:rm-bz2-check
Jan 22, 2024
Merged

Remove disputed bz2 check#42821
come-nc merged 1 commit into
nextcloud:masterfrom
J0WI:rm-bz2-check

Conversation

@J0WI

@J0WIJ0WI commented Jan 15, 2024•
edited by come-nc
Loading

Copy link
Copy Markdown
Contributor

Summary

This is fixing kind of a regression of #40889 by restoring the previous behavior. The regression and reason is described in #42342.

TODO

Checklist

@J0WI

J0WI commented Jan 15, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@J0WI

J0WI commented Jan 15, 2024

Copy link
Copy Markdown
ContributorAuthor

/rebase

@J0WI
Remove disputed bz2 check
1cb7ccf
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@J0WI
J0WI requested review from Altahrim and come-ncJanuary 18, 2024 20:24
@J0WIJ0WI mentioned this pull request Jan 18, 2024
Closed
joshtrichards
joshtrichards approved these changes Jan 19, 2024
View reviewed changes

@joshtrichardsjoshtrichards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM per my comments on docs PR + the related issue in server

@joshtrichardsjoshtrichards added the 3. to review Waiting for reviews label Jan 19, 2024
@J0WIJ0WI added this to the Nextcloud 28.0.2 milestone Jan 19, 2024
@J0WIJ0WI added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 19, 2024
This was referenced Jan 22, 2024
Closed
Merged
@blizzz

blizzz commented Jan 22, 2024

Copy link
Copy Markdown
Member

master is 29, fixed the milestone

@come-nc

come-nc commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

/backport to stable28

@come-nc
come-nc merged commit d515227 into nextcloud:masterJan 22, 2024
@backportbotbackportbotBot mentioned this pull request Jan 22, 2024
Merged
@J0WI
J0WI deleted the rm-bz2-check branch January 23, 2024 23:52
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshtrichardsjoshtrichardsjoshtrichards approved these changes
@AltahrimAltahrimAltahrim approved these changes
@come-nccome-nccome-nc approved these changes

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

Clarification: Is bz2 still really recommended PHP module?

5 participants

@J0WI@blizzz@come-nc@joshtrichards@Altahrim