Skip to content

[stable28] Remove disputed bz2 check - #43013

Merged
susnux merged 1 commit into
stable28from
backport/42821/stable28
Feb 2, 2024
Merged

[stable28] Remove disputed bz2 check#43013
susnux merged 1 commit into
stable28from
backport/42821/stable28

Conversation

@backportbot

Copy link
Copy Markdown

Backport of PR #42821

@backportbotbackportbotBot added the 3. to review Waiting for reviews label Jan 22, 2024
@backportbotbackportbotBot added this to the Nextcloud 28.0.2 milestone Jan 22, 2024
@AltahrimAltahrim mentioned this pull request Jan 22, 2024
@joshtrichardsjoshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 22, 2024
@joshtrichards

Copy link
Copy Markdown
Member

Someone with power will have to override for merge during freeze.

The cypress failures appear completely unrelated:

 1) Files: Move or copy files
Can copy a file to new folder:
AssertionError: Timed out retrying after 4000ms: Expected to find element: `[data-cy-files-list-row-name="original.txt"]`, but never found it.
at Context.eval (webpack://nextcloud/./cypress/e2e/files/files_copy-move.cy.ts:55:38)
2) Files: Move or copy files
Can move a file to its parent folder:
AssertionError: Timed out retrying after 4000ms: Expected to find content: 'No files in here' within the element: <main#app-content-vue.app-content.no-snapper> but never did.
at Context.eval (webpack://nextcloud/./cypress/e2e/files/files_copy-move.cy.ts:116:52)

@blizzz

Copy link
Copy Markdown
Member

Not considered critical → 28.0.3

@joshtrichards

joshtrichards commented Jan 22, 2024

Copy link
Copy Markdown
Member

Not considered critical → 28.0.3

Agreed, I guess, but just a soft nudge and I'll leave it at that 😄 It's a support / user experience matter (with the setup checks) and bug triage time waster. In the docker repo alone, the addition of this check in v28 generated over 75 upvotes and 48 comments just in the past 30 days: nextcloud/docker#2118

@come-nc

Copy link
Copy Markdown
Contributor

Not considered critical → 28.0.3

Agreed, I guess, but just a soft nudge and I'll leave it at that 😄 It's a support / user experience matter (with the setup checks) and bug triage time waster. In the docker repo alone, the addition of this check in v28 generated over 75 upvotes and 48 comments just in the past 30 days: nextcloud/docker#2118

People can ignore the warning or install the module, there is nothing critical about this.

@blizzz

Copy link
Copy Markdown
Member

We had already crowded RCs on 28 after the first one, with just important considered PRs. At this stage of a release, the less the better. More, even if they look innocent, just muddy the water while the testing time is very short.

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@susnux
susnuxforce-pushed the backport/42821/stable28 branch from 976b564 to d8ba5f6CompareFebruary 2, 2024 14:34
@susnux
susnux merged commit eab6b49 into stable28Feb 2, 2024
@susnux
susnux deleted the backport/42821/stable28 branch February 2, 2024 16:07
@skjnldsvskjnldsv mentioned this pull request Feb 14, 2024
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@joshtrichards@blizzz@come-nc@Altahrim@susnux@J0WI