Skip to content

[stable28] fix(theming): Apply same logic on capabilities for primary color as done on themes - #43032

Merged
blizzz merged 1 commit into
stable28from
fix/stable28-capabilities
Jan 23, 2024
Merged

[stable28] fix(theming): Apply same logic on capabilities for primary color as done on themes#43032
blizzz merged 1 commit into
stable28from
fix/stable28-capabilities

Conversation

@susnux

@susnuxsusnux commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

Summary

On themes we replace the default color with the accessible color, so we also need to do this on the capabilities.
This worked previously but as we now enforce contrasts of the text color clients that use the capabilities changes to black text on that color.

Checklist

@susnuxsusnux added this to the Nextcloud 28.0.2 milestone Jan 22, 2024
@susnuxsusnux changed the title [stable28] fix(theming): Apply same logic on capabilities for primary color like on themes[stable28] fix(theming): Apply same logic on capabilities for primary color as done on themesJan 22, 2024
@provokateurin
provokateurin removed their request for review January 22, 2024 17:54
@SystemKeeper

Copy link
Copy Markdown
Contributor

For my understanding, why not adjust this in

publicfunctiongetTextColorPrimary() {
return$this->util->invertTextColor($this->getColorPrimary()) ? '#000000' : '#ffffff';
}

🤔

@susnux

Copy link
Copy Markdown
ContributorAuthor

For my understanding, why not adjust this in

Better would be in getColorPrimary, but that would have greater consequences especially for a stable branch I would not change that API and just fix the usage here.

For a general fix I currently prepare this one: #42977

@sorbaughsorbaugh mentioned this pull request Jan 22, 2024
@blizzz

This comment was marked as resolved.

@susnux
susnuxforce-pushed the fix/stable28-capabilities branch 2 times, most recently from f70a37b to d2d5e7dCompareJanuary 22, 2024 19:53
@blizzz

This comment was marked as resolved.

… on themes
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the fix/stable28-capabilities branch from d2d5e7d to afa56bbCompareJanuary 23, 2024 00:01
@susnuxsusnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 23, 2024
@susnux

Copy link
Copy Markdown
ContributorAuthor

cypress unrelated

@blizzz
blizzz merged commit 667b0bc into stable28Jan 23, 2024
@blizzz
blizzz deleted the fix/stable28-capabilities branch January 23, 2024 09:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: theming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@susnux@SystemKeeper@blizzz@skjnldsv@Pytal@sorbaugh