Skip to content

fix(theming): Apply same logic on capabilities for primary color as done on themes - #43033

Merged
susnux merged 1 commit into
masterfrom
fix/color-capabilities
Jan 23, 2024
Merged

fix(theming): Apply same logic on capabilities for primary color as done on themes#43033
susnux merged 1 commit into
masterfrom
fix/color-capabilities

Conversation

@susnux

Copy link
Copy Markdown
Contributor

Summary

On themes we replace the default color with the accessible color, so we also need to do this on the capabilities.
This worked previously but as we now enforce contrasts of the text color clients that use the capabilities changes to black text on that color.

Checklist

@susnux
susnuxforce-pushed the fix/color-capabilities branch 2 times, most recently from 07e8672 to cfbca20CompareJanuary 22, 2024 19:53
… on themes
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the fix/color-capabilities branch from cfbca20 to 8de89b2CompareJanuary 23, 2024 00:01
@susnux

Copy link
Copy Markdown
ContributorAuthor

Maybe we should after all fix this in OCA\ThemingDefaults instead. Because that would fix #43043
(even if that means more tests need to be adjusted, as we basically then will nowhere have the default color anymore but just the default accessible color).

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 23, 2024
@susnux
susnux merged commit 8ba7de8 into masterJan 23, 2024
@susnux
susnux deleted the fix/color-capabilities branch January 23, 2024 17:32
@blizzzblizzz mentioned this pull request Mar 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: themingregression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux@skjnldsv@Pytal@provokateurin