Uh oh!
There was an error while loading. Please reload this page.
Show quick permission subline on newline - #43333
Merged
Merged
Conversation
nfebe
commented
Feb 4, 2024
Contributor
| Before | After |
|---|---|
 |  |
- Show quick permission details/explanations on subline
- Fix icon colors, should be white (or component set color) when highlighted.
- Resolves: Custom permission subline displays as part of headline on master #43225
nfebe
commented
Feb 4, 2024
ContributorAuthor
/compile |
susnux
reviewed
Feb 4, 2024
Uh oh!
There was an error while loading. Please reload this page.
nfebeforce-pushed
the
43225-fix-share-quick-perms-subline
branch
2 times, most recently
from
February 4, 2024 21:57
501b3fd to
62d08cdCompare- Show quick permission details/explanations on subline - Fix icon colors, should be white (or component set color) when highlighted. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebeforce-pushed
the
43225-fix-share-quick-perms-subline
branch
from
February 4, 2024 22:02
62d08cd to
60959dbComparenfebe
commented
Feb 4, 2024
ContributorAuthor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
emoral435
approved these changes
Feb 5, 2024
emoral435
left a comment
Contributor
There was a problem hiding this comment.
IMO, to me, this change looks way cleaner than having the smaller text right next to the big text. I will cc desginers to get them on the same page, though. cc @nextcloud/designers
szaimen
approved these changes
Feb 5, 2024
szaimen
left a comment
Contributor
There was a problem hiding this comment.
Yes, looks much nicer from design perspective (didnt test and didnt review the code)
susnux
approved these changes
Feb 5, 2024
susnux
commented
Feb 5, 2024
Contributor
backport? |
nfebe
commented
Feb 5, 2024
ContributorAuthor
think at least for 28! 27 seems fine. |
nfebe
commented
Feb 5, 2024
ContributorAuthor
/backport to stable28 |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.