Skip to content

[stable28] Show quick permission subline on newline - #43367

Closed
backportbot[bot] wants to merge 2 commits into
stable28from
backport/43333/stable28
Closed

[stable28] Show quick permission subline on newline#43367
backportbot[bot] wants to merge 2 commits into
stable28from
backport/43333/stable28

Conversation

@backportbot

@backportbotbackportbotBot commented Feb 5, 2024

Copy link
Copy Markdown

Backport of #43333

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove [skip ci] tag

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

- Show quick permission details/explanations on subline
- Fix icon colors, should be white (or component set color) when highlighted.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe
nfebeforce-pushed the backport/43333/stable28 branch from a6e1e59 to c994094CompareFebruary 5, 2024 22:27
@nfebe

nfebe commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

/compile

@nfebe
nfebe marked this pull request as ready for review February 5, 2024 22:27
@nfebe
nfebe enabled auto-merge February 5, 2024 22:28
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe
nfebe disabled auto-merge February 5, 2024 22:46

@nfebenfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not plug and play on 28.

This was referenced Feb 14, 2024
@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 22, 2024
@skjnldsv
skjnldsv marked this pull request as draft February 29, 2024 10:35
@nfebe

Copy link
Copy Markdown
Contributor

Closing in favor of #44217

@nfebenfebe closed this Mar 15, 2024
@szaimen
szaimen deleted the backport/43333/stable28 branch March 15, 2024 15:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nfebe@skjnldsv@nextcloud-command