Skip to content

feat: include file id in audit logs - #44871

Merged
yemkareems merged 1 commit into
masterfrom
feature/include-file-id-in-audit-logs
Apr 30, 2024
Merged

feat: include file id in audit logs#44871
yemkareems merged 1 commit into
masterfrom
feature/include-file-id-in-audit-logs

Conversation

@yemkareems

@yemkareemsyemkareems commented Apr 17, 2024•
edited by come-nc
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Few logs are changed after this implementation. Find attached is the file of logs before and after this implementation
    nc.logs.txt

Checklist

@yemkareemsyemkareems added this to the Nextcloud 30 milestone Apr 17, 2024
@yemkareemsyemkareems self-assigned this Apr 17, 2024
artonge
artonge reviewed Apr 17, 2024
View reviewed changes

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

Comment threadapps/admin_audit/lib/Actions/Files.php Outdated
Comment threadapps/admin_audit/lib/Actions/Files.php Outdated
Comment threadapps/admin_audit/lib/AppInfo/Application.php
artonge
artonge reviewed Apr 17, 2024
View reviewed changes
Comment threadapps/admin_audit/lib/AppInfo/Application.php Outdated
@szaimen

szaimen commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

Sorry, don't feel confident enough to review this

@szaimen
szaimen removed their request for review April 18, 2024 08:27
come-nc
come-nc reviewed Apr 22, 2024
View reviewed changes
Comment threadapps/admin_audit/lib/AppInfo/Application.php Outdated
Comment threadapps/admin_audit/lib/Actions/Files.php
Comment on lines +197 to +220
} catch (InvalidPathException|NotFoundException $e) {
return;

@come-nccome-ncApr 22, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should still log something, maybe even on error level, so that this is not missed.

@yemkareemsyemkareemsApr 24, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@come-nc logging the exception message as error in log file. I tried to delete a file that is already deleted from oc_filecache and also removed from data/admin/files/log.txt. I get a message in the UI saying "Delete file" action failed but i did not find it getting logged as a error message

@come-nc

come-nc commented Apr 22, 2024

Copy link
Copy Markdown
Contributor

Please also fix commit names, should not all start with feat:, see https://www.conventionalcommits.org/en/v1.0.0/
Would be good to use the opportunity to also squash them into something like 2 commits only, one for event refactor and one for adding id to logs.

@come-nccome-nc changed the title Feature/include file id in audit logsfeat: include file id in audit logsApr 22, 2024
come-nc
come-nc reviewed Apr 29, 2024
View reviewed changes
Comment threadapps/admin_audit/lib/Actions/Action.php Outdated
Comment on lines +90 to +97

/**
* Log a error message with a log level of error
* @param string $text
*/
public function error(string $text): void {
$this->logger->error($text, ['app' => 'admin_audit']);
}

@come-nccome-ncApr 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this method, it makes thing unnecessiraly convoluted.
Inject the loggen in the child class if possible, use \OCP\Server::get if not.

@yemkareems
yemkareemsforce-pushed the feature/include-file-id-in-audit-logs branch 3 times, most recently from 6ed0835 to 977bf8eCompareApril 29, 2024 09:53
come-nc
come-nc reviewed Apr 29, 2024
View reviewed changes
Comment threadapps/admin_audit/lib/Actions/Files.php Outdated
@yemkareems
yemkareemsforce-pushed the feature/include-file-id-in-audit-logs branch 2 times, most recently from bc3e830 to 710f11dCompareApril 29, 2024 10:10
come-nc
come-nc reviewed Apr 29, 2024
View reviewed changes

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commit description:
Copie d'écran_20240429_132314

@yemkareems
yemkareemsforce-pushed the feature/include-file-id-in-audit-logs branch from 710f11d to 7b0b54fCompareApril 29, 2024 12:04
@yemkareems@come-nc
feat: include file id in audit logs
4d22880
Signed-off-by: yemkareems <yemkareems@gmail.com>
@come-nc
come-ncforce-pushed the feature/include-file-id-in-audit-logs branch from 7b0b54f to 4d22880CompareApril 30, 2024 09:31
@yemkareems
yemkareems merged commit 66aad43 into masterApr 30, 2024
@yemkareems
yemkareems deleted the feature/include-file-id-in-audit-logs branch April 30, 2024 11:59
@blizzzblizzz mentioned this pull request Jul 24, 2024
Merged
@nickvergessennickvergessen mentioned this pull request Aug 15, 2024
Merged
4 tasks
@juliusknorrjuliusknorr mentioned this pull request Aug 28, 2024
Merged
@come-nccome-nc mentioned this pull request Oct 3, 2024
Merged
4 tasks
@come-nccome-nc mentioned this pull request Feb 24, 2025
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwl

Assignees

@yemkareemsyemkareems

Labels

3. to reviewWaiting for reviewsenhancementfeature: admin audit

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

4 participants

@yemkareems@szaimen@come-nc@artonge