fix: Do not fail to get internal path on NonExistingFile

[juliusknorr]

Follow up to:

• fix(adminaudit): Don't crash when creating folder #47252
• feat: include file id in audit logs #44871

Summary

If we cannot get the internal path from the file info (e.g. when creating a new file), but we can obtain it from the parent node through the mountpoint.

Fixes errors log spam when creating a new file and having admin_audit enabled when being called in

server/apps/admin_audit/lib/Actions/Files.php

Line 166 in af6de04

'path' => mb_substr($node->getInternalPath(), 5),

[nickvergessen]

Just for the record, if you did this because you see it on our instance, the stable30 backport was merged after the last RC

[juliusknorr]

I noticed on our instance but it was still an issue on master, the previous fixes only tackled getId() not getInternalPath() which is also not throwing on NonExistingFile instances

(edit: I'm not sure why I didn't catch this when testing the earlier PR i did)

[nickvergessen]

NonExistingFolder needs the same fix? and did you also try "read" operation paths from admin_audit

[juliusknorr]

Reads are not affected as the file already exists then, but added the same for folder creation on NonExistingFolder

[juliusknorr]

/backport to stable30

[juliusknorr]

/backport to stable30

[backportbot]

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47581/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 61108882
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47581/stable30

Error: Failed to clone repository: Failed to checkout branches: error: Your local changes to the following files would be overwritten by checkout:
dist/3794-3794.js.map.license
dist/4546-4546.js.map.license
dist/4696-4696.js.map.license
dist/5643-5643.js.map.license
dist/583-583.js.map.license
dist/9972-9972.js.map.license
Please commit your changes or stash them before you switch branches.
Aborting

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[skjnldsv]

/backport to stable30

[skjnldsv]

/backport to stable30