Skip to content

fix: Do not import from axios but only @nextcloud/axios - #45161

Merged
susnux merged 2 commits into
masterfrom
fix/import-axios
Jun 20, 2024
Merged

fix: Do not import from axios but only @nextcloud/axios#45161
susnux merged 2 commits into
masterfrom
fix/import-axios

Conversation

@susnux

@susnuxsusnux commented May 2, 2024

Copy link
Copy Markdown
Contributor

Summary

Do not import from axios this is extranous, but only from @nextcloud/axios.

Checklist

@susnuxsusnux added bug 3. to review Waiting for reviews labels May 2, 2024
@susnuxsusnux added this to the Nextcloud 30 milestone May 2, 2024
@susnux
susnux requested review from Pytal and nfebeMay 2, 2024 20:18
@susnux
susnux requested a review from skjnldsv as a code ownerMay 2, 2024 20:18
Comment threadapps/settings/src/utils/handlers.ts Outdated
@susnux
susnuxforce-pushed the fix/import-axios branch 4 times, most recently from 55fd721 to 65973d0CompareMay 6, 2024 18:18
@skjnldsv

Copy link
Copy Markdown
Member

Can you explain 65973d0 ? :)

@susnux

Copy link
Copy Markdown
ContributorAuthor

Can you explain 65973d0 ? :)

See if CI gets green, because currently this is blocked (that commit is from #45207 ). Meaning we can not use latest @nextcloud/axios because webdav does not work with X-Requested-With: XMLHttpRequest.

CI looks good so dropped the commit again, but adjusted the target so we chain onto #45207

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 24, 2024
@susnux

Copy link
Copy Markdown
ContributorAuthor

Still waiting for #45207

Base automatically changed from fix/webdav-aja to masterJune 20, 2024 10:28
susnux added 2 commits June 20, 2024 12:34
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux merged commit 8ac9e08 into masterJun 20, 2024
@susnux
susnux deleted the fix/import-axios branch June 20, 2024 13:06
@blizzzblizzz mentioned this pull request Jul 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@susnux@skjnldsv@miaulalala@Pytal@ChristophWurst