Skip to content

fix(dav): Try basic auth for ajax WebDAV requests - #45207

Merged
susnux merged 1 commit into
masterfrom
fix/webdav-aja
Jun 20, 2024
Merged

fix(dav): Try basic auth for ajax WebDAV requests#45207
susnux merged 1 commit into
masterfrom
fix/webdav-aja

Conversation

@susnux

Copy link
Copy Markdown
Contributor

Summary

Allow using basic auth with ajax requests on WebDAV.
The idea why the code was added in the first place was to ensure that if basic auth fails the user gets not asked by the browser for the correct credentials.
We still keep this behavior by throwing a 401 error in case of failed basic auth.

Checklist

@susnuxsusnux added this to the Nextcloud 30 milestone May 6, 2024
@susnux

Copy link
Copy Markdown
ContributorAuthor

The problem gets visible because previous versions of @nextcloud/axios were not setting the header, but the latest version will set the X-Requested-With header by default.

Meaning the alternative to this is to drop the X-Requested-With: XMLHttpRequest from axios requests to DAV like we were doing with current versions (currently we do not set X-Requested-With for ajax requests to DAV to prevent this.
So I think this solution here is cleaner than faking the kind of request 😅

Comment threadapps/dav/tests/unit/Connector/Sabre/AuthTest.php Outdated
@susnux
susnux requested a review from AltahrimMay 7, 2024 16:29
nickvergessen
nickvergessen previously requested changes May 8, 2024

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking temporarily

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux dismissed nickvergessen’s stale reviewJune 19, 2024 11:52

Tested and concerned issue is not happening

@susnux
susnux merged commit c251e8f into masterJun 20, 2024
@susnux
susnux deleted the fix/webdav-aja branch June 20, 2024 10:28
@blizzzblizzz mentioned this pull request Jul 24, 2024
@sorbaugh

Copy link
Copy Markdown
Contributor

/backport to stable29

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@susnux@sorbaugh@nickvergessen@icewind1991@come-nc