Uh oh!
There was an error while loading. Please reload this page.
fix(files): Properly handle denied ownership transfers - #45884
Merged
Conversation
When the receiver denies the transfer the notification handler was missing, so no notification was created for the transfer owner. But also the internal notification was created two times: 1. When rejecting the transfer 2. By the reject function when dismissing the notification This is fixed by only relying on the dismiss function. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
a team, ArtificialOwl, SystemKeeper, nfebe and yemkareems
and removed request for
a teamJune 14, 2024 15:39
susnux
commented
Jun 14, 2024
ContributorAuthor
/backport to stable29 |
susnux
commented
Jun 14, 2024
ContributorAuthor
/backport to stable28 |
come-nc
approved these changes
Jun 17, 2024
This was referenced Jun 17, 2024
botsarenthuman
commented
Jun 25, 2024
Is there a test to cover this actually works? |
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the receiver denies the transfer the notification handler was missing, so no notification was created for the transfer owner.
But also the internal notification was created two times:
This is fixed by only relying on the dismiss function.
Checklist