Uh oh!
There was an error while loading. Please reload this page.
fix: get rid of denied notification when accept - #48734
Merged
Merged
Conversation
Antreesyforce-pushed
the
fix/45884/accept-notification
branch
2 times, most recently
from
October 16, 2024 13:14
56ed136 to
b9c5fd4CompareAntreesy
marked this pull request as ready for review
October 16, 2024 13:15
nickvergessen
approved these changes
Oct 16, 2024
juliusknorr
approved these changes
Oct 16, 2024
susnux
approved these changes
Oct 16, 2024
- do not create 'denied' notification if bg job exists Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- this reverts 1e8048a Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesyforce-pushed
the
fix/45884/accept-notification
branch
from
October 16, 2024 15:32
b9c5fd4 to
73b34bbCompareAntreesy
enabled auto-merge
October 16, 2024 15:32
nickvergessen
disabled auto-merge
October 17, 2024 06:39
Antreesy
commented
Oct 17, 2024
ContributorAuthor
/backport to stable30 |
Antreesy
commented
Oct 17, 2024
ContributorAuthor
/backport to stable29 |
Antreesy
commented
Oct 17, 2024
ContributorAuthor
/backport to stable28 |
This was referenced Oct 17, 2024
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acceptandrejectmark notification as processed, which ends up indismissNotification()acceptBG job is created, we check it on dismiss: if BG job is there, transfer was accepted, otherwise - deniedTODO
Checklist