Skip to content

fix(carddav): limit vcard size - #46193

Merged
st3iny merged 1 commit into
masterfrom
fix/limit-vcard-size
Jul 4, 2024
Merged

fix(carddav): limit vcard size#46193
st3iny merged 1 commit into
masterfrom
fix/limit-vcard-size

Conversation

@SebastianKrupinski

@SebastianKrupinskiSebastianKrupinski commented Jun 28, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Resolves: Card size limit

@tcitworld

tcitworld commented Jun 28, 2024

Copy link
Copy Markdown
Member

Ah, this reminds me I never added the repair steps I was talking about here: nextcloud/contacts#2743

github-advanced-security[bot]
github-advanced-securityAI found potential problems Jul 1, 2024
View reviewed changes
Comment threadapps/dav/lib/CardDAV/CardDavBackend.php Fixed
Comment threadapps/dav/lib/CardDAV/CardDavBackend.php Fixed
Comment threadapps/dav/lib/CardDAV/CardDavBackend.php Fixed
Comment threadapps/dav/lib/CardDAV/CardDavBackend.php Fixed
@SebastianKrupinski

SebastianKrupinski commented Jul 1, 2024

Copy link
Copy Markdown
ContributorAuthor

Ah, this reminds me I never added the repair steps I was talking about here: nextcloud/contacts#2743

@tcitworld Are you going to write the repair step? If you are I modified the PR to use a configurable app setting, please use the same setting for the repair step.

github-advanced-security[bot]
github-advanced-securityAI found potential problems Jul 1, 2024
View reviewed changes
Comment threadapps/dav/lib/CardDAV/CardDavBackend.php Fixed
Comment threadapps/dav/lib/CardDAV/CardDavBackend.php Fixed
kesselb
kesselb reviewed Jul 1, 2024
View reviewed changes
Comment threadapps/dav/lib/CardDAV/CardDavBackend.php Outdated
st3iny
st3iny approved these changes Jul 4, 2024
View reviewed changes

@st3inyst3iny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SebastianKrupinski
fix(carddav): limit vcard size
cb6c091
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@st3iny
st3iny enabled auto-merge July 4, 2024 20:43
@st3iny
st3iny merged commit a8e581c into masterJul 4, 2024
@st3iny
st3iny deleted the fix/limit-vcard-size branch July 4, 2024 22:08
@SebastianKrupinski

SebastianKrupinski commented Jul 4, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@backportbotbackportbotBot mentioned this pull request Jul 4, 2024
Merged
@SebastianKrupinski

SebastianKrupinski commented Jul 4, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@SebastianKrupinski

SebastianKrupinski commented Jul 4, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@backportbotbackportbotBot mentioned this pull request Jul 4, 2024
Merged
@backportbotbackportbotBot mentioned this pull request Jul 4, 2024
Merged
@SebastianKrupinskiSebastianKrupinski added this to the Nextcloud 30 milestone Jul 23, 2024
@SebastianKrupinskiSebastianKrupinski added the feature: carddav Related to CardDAV internals label Jul 23, 2024
@blizzzblizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbkesselb left review comments
@st3inyst3inyst3iny approved these changes
@hamza221hamza221hamza221 approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@miaulalalamiaulalalaAwaiting requested review from miaulalala
@tcitworldtcitworldAwaiting requested review from tcitworld

Assignees

No one assigned

Labels

feature: carddavRelated to CardDAV internals

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

6 participants

@SebastianKrupinski@tcitworld@st3iny@kesselb@hamza221@github-advanced-security