Skip to content

[stable28] fix(carddav): limit vcard size - #46313

Merged
st3iny merged 1 commit into
stable28from
backport/46193/stable28
Jul 10, 2024
Merged

[stable28] fix(carddav): limit vcard size#46313
st3iny merged 1 commit into
stable28from
backport/46193/stable28

Conversation

@backportbot

@backportbotbackportbotBot commented Jul 4, 2024

Copy link
Copy Markdown

Backport of PR #46193

@backportbot
backportbotBot requested a review from hamza221July 4, 2024 22:17
@backportbot
backportbotBot requested a review from tcitworld as a code ownerJuly 4, 2024 22:17
@backportbotbackportbotBot added the 3. to review Waiting for reviews label Jul 4, 2024
@backportbotbackportbotBot added this to the Nextcloud 28.0.8 milestone Jul 4, 2024
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jul 4, 2024
View reviewed changes
Comment threadapps/dav/lib/CardDAV/Validation/CardDavValidatePlugin.php Fixed
@SebastianKrupinski
SebastianKrupinskiforce-pushed the backport/46193/stable28 branch 2 times, most recently from 4d3e97f to 2701f10CompareJuly 4, 2024 23:41
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jul 4, 2024
View reviewed changes
Comment threadapps/dav/lib/CardDAV/Validation/CardDavValidatePlugin.php Fixed
@SebastianKrupinski
SebastianKrupinskiforce-pushed the backport/46193/stable28 branch 2 times, most recently from 2a0a7f4 to e2bd10eCompareJuly 5, 2024 16:50
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jul 5, 2024
View reviewed changes
Comment threadapps/dav/lib/CardDAV/Validation/CardDavValidatePlugin.php Fixed
@ChristophWurst

ChristophWurst commented Jul 9, 2024

Copy link
Copy Markdown
Member

OCA\DAV\Tests\unit\CardDAV\Validation\CardDavValidatePluginTest::testPutSizeLessThenLimit
PHPUnit\Framework\MockObject\MethodCannotBeConfiguredException: Trying to configure method "getValue" which cannot be configured because it does not exist, has not been specified, is final, or is static

unit tests 😍

@AltahrimAltahrim mentioned this pull request Jul 10, 2024
Merged
@AndyScherzinger
AndyScherzingerforce-pushed the backport/46193/stable28 branch from 3e7292b to 8ecfbc7CompareJuly 10, 2024 13:14
@SebastianKrupinski
fix(carddav): limit vcard size
cce9558
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@st3iny
st3iny merged commit 63acc67 into stable28Jul 10, 2024
@st3iny
st3iny deleted the backport/46193/stable28 branch July 10, 2024 18:38
@st3inyst3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 10, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solracsfsolracsfsolracsf left review comments
@st3inyst3inyst3iny approved these changes
@SebastianKrupinskiSebastianKrupinskiSebastianKrupinski approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@miaulalalamiaulalalaAwaiting requested review from miaulalala
@hamza221hamza221Awaiting requested review from hamza221hamza221 is a code owner
@tcitworldtcitworldAwaiting requested review from tcitworld

Assignees

@SebastianKrupinskiSebastianKrupinski

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 28.0.8

Development

Successfully merging this pull request may close these issues.

6 participants

@ChristophWurst@st3iny@miaulalala@solracsf@github-advanced-security@SebastianKrupinski