Uh oh!
There was an error while loading. Please reload this page.
fix(SharingDetailsView): Prevent illegal unselection of read permissions - #46321
Merged
Conversation
nfebe
requested review from
a team, Pytal, skjnldsv and sorbaugh
and removed request for
a teamJuly 5, 2024 20:29
nfebe
marked this pull request as ready for review
July 5, 2024 20:29
artonge
reviewed
Jul 8, 2024
Uh oh!
There was an error while loading. Please reload this page.
artonge
approved these changes
Jul 8, 2024
Pytal
approved these changes
Jul 8, 2024
nfebe
commented
Jul 8, 2024
ContributorAuthor
/compile |
With the exception of "file drop" on link shares all other shares need the read permissions at least. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebeforce-pushed
the
fix/46195/feedback-no-read-perms
branch
from
July 8, 2024 19:33
656e109 to
4833950CompareSigned-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nfebe
commented
Jul 9, 2024
ContributorAuthor
/backport to stable29 |
nfebe
commented
Jul 9, 2024
ContributorAuthor
/backport to stable28 |
nfebe
commented
Jul 9, 2024
ContributorAuthor
/backport to stable27 |
2 tasks
This was referenced Jul 9, 2024
skjnldsv
commented
Jul 18, 2024
Member
Read permissions are also removable on email shares 😨 |
This was referenced Jul 18, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the exception of "file drop" on link shares all other shares need the read permissions at least.
Resolves : #46195