Uh oh!
There was an error while loading. Please reload this page.
[stable28] fix(SharingDetailsView): Prevent illegal unselection of read permissions - #46364
Merged
Conversation
solracsf
marked this pull request as ready for review
July 9, 2024 11:31
solracsf
marked this pull request as draft
July 9, 2024 11:32
With the exception of "file drop" on link shares all other shares need the read permissions at least. Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
backport/46321/stable28
branch
from
July 9, 2024 11:43
0c992da to
710287fComparenfebe
approved these changes
Jul 9, 2024
nfebe
marked this pull request as ready for review
July 9, 2024 13:04
nfebe
enabled auto-merge
July 9, 2024 13:05
susnux
approved these changes
Jul 9, 2024
Merged
| // allowed to revoke it too (but not to grant it again). | ||
| return (this.fileInfo.canDownload() || this.canDownload) | ||
| }, | ||
| canRemoveReadPermission() { |
There was a problem hiding this comment.
https://github.com/nextcloud/server/pull/46362/files#diff-beddba792d435cad32b7d4c6445df48fd52e29a9e3a1ddf3d7ab79b92f693c6bL179 is missing in 28
it's there in 27, 29 and master....
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #46321
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.