Uh oh!
There was an error while loading. Please reload this page.
fix: use non-mocked app manager for router test - #46416
Closed
kesselb wants to merge 2 commits into
Closed
Conversation
The mocked version of IAppManager will return null for getAppPath and thus parts of the tests are not executed. To avoid more mocking a "partly" mocked IAppManager instanced is used. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselbforce-pushed
the
bug/noid/more-routing-weirdness
branch
from
July 10, 2024 22:27
44d8d0f to
b8a0401Compareskjnldsv
marked this pull request as draft
November 15, 2024 13:07
kesselb
commented
Jun 10, 2025
ContributorAuthor
Replaced by #47927 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The mocked version of IAppManager will return null for getAppPath and thus parts of the tests are not executed.
To avoid more mocking a "partly" mocked IAppManager instanced is used.
TODO
Checklist