Uh oh!
There was an error while loading. Please reload this page.
Migrate away from OC_App to IAppManager - #47927
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
07141d5 to
2abf2d8Compare…_App Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2abf2d8 to
7a16d01CompareUh oh!
There was an error while loading. Please reload this page.
| return \OCP\Server::get(IAppManager::class)->getAllAppsInAppsFolders(); | ||
| } | ||
| /** |
There was a problem hiding this comment.
Can we also deprecate this in favor of \OCP\Support\Subscription\IRegistry::delegateGetSupportedApps ?
There was a problem hiding this comment.
Why the opposite?
@susnux yeah we should. But I won’t do it in this PR to keep it mergeable. This kind of cleanup needs to be merged quickly or it conflicts fast.
There was a problem hiding this comment.
Why the opposite?
From my perspective the subscription methods are "internal" and are used by (other) public components.
All the delegate*() functions are only called from "lib/private/ implementing public interfaces", settings app, support app or update checks.
There was a problem hiding this comment.
Maybe getSupportedApps can be moved to the AppManager then.
In the mean time, would one of you two approve this here PR? :-P
Follow-up of #44025
Summary
Migrate most calls of
OC_App::getAppPath,OC_App::cleanAppId,OC_App::getAllAppsto calls on the AppManager instance. The later two were added to the OCP interface for the occasion.Checklist