Skip to content

Use logical positioning instead of physical for bidirectional text support - #47343

Merged
skjnldsv merged 7 commits into
masterfrom
feat/31420/add-bidi-support
Aug 29, 2024
Merged

Use logical positioning instead of physical for bidirectional text support#47343
skjnldsv merged 7 commits into
masterfrom
feat/31420/add-bidi-support

Conversation

@AndyScherzinger

@AndyScherzingerAndyScherzinger commented Aug 20, 2024

Copy link
Copy Markdown
Member

Summary

This PR is the first step towards adding bidirectional text support to the Nextcloud ecosystem. It affects the entire project; accordingly, each app should have subsequent PRs.

The PR is 90+ percent complete. I decided to make the PR to

  • Get early feedback to ensure it is on the right path.
  • Discuss some technical challenges.

I had challenges in building the project. Generating css files and the dist directory during development is something I am uncomfortable with.

Because of supporting Samsung Internet, I needed to take some hacky approach.

Note:
We must update many components in NextCloud/vue. The most important one was the header-menu vue component which is already updated. Others will come soon. First, I need to ensure this PR is getting prepared for merge.

Screenshots

BeforeAfter
imageimage
imageimage

TODO

Checklist

@skjnldsv

skjnldsv commented Aug 20, 2024

Copy link
Copy Markdown
Member

Files potentially missing some code change from previous PR:

  • apps/files_reminders/src/components/setcustomremindermodal.vue
  • apps/files_sharing/src/components/sharingentryquickshareselect.vue
  • apps/settings/src/components/applist/appitem.vue
  • apps/settings/src/components/personalinfo/emailsection/email.vue
  • apps/settings/src/views/apps.vue
  • apps/updatenotification/src/components/updatenotification.vue
  • apps/user_status/src/userstatus.vue
  • core/src/components/usermenu/usermenuentry.vue
  • core/src/views/usermenu.vue

Comment threadlib/private/L10N/Factory.php Outdated
Comment threadlib/public/L10N/IFactory.php Outdated
@nickvergessen

Copy link
Copy Markdown
Member

Backend part moved to #47349

Comment threadcore/src/components/Profile/PrimaryActionButton.vue Outdated
Comment threadcore/src/views/Profile.vue Outdated
@susnux
susnuxforce-pushed the feat/31420/add-bidi-support branch from 6e73d75 to 55dd692CompareAugust 20, 2024 17:42
@susnuxsusnux changed the title WIP - Add bidirectional text supportUse logical positioning instead of physical for bidirectional text supportAug 20, 2024

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test seems to work fine, but some comments.

Comment threadapps/dashboard/src/DashboardApp.vue Outdated
Comment threadapps/dashboard/src/DashboardApp.vue Outdated
Comment threadapps/files/css/detailsView.scss Outdated
Comment threadapps/files/css/files.scss Outdated
Comment threadapps/files/css/files.scss Outdated
Comment threadcore/css/guest.scss Outdated
Comment threadcore/css/guest.scss Outdated
Comment threadcore/css/systemtags.scss Outdated
Comment threadcore/src/views/LegacyUnifiedSearch.vue Outdated
Comment threadcore/src/views/LegacyUnifiedSearch.vue Outdated
@susnux
susnuxforce-pushed the feat/31420/add-bidi-support branch from 4527b31 to b789d58CompareAugust 20, 2024 21:04
@AndyScherzinger
AndyScherzingerforce-pushed the feat/31420/add-bidi-support branch from b789d58 to c490feaCompareAugust 22, 2024 17:12
@susnux
susnuxforce-pushed the feat/31420/add-bidi-support branch 3 times, most recently from 7ccea6d to 7e6f6fdCompareAugust 27, 2024 20:10

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, could not find any regressions with LTR language.
So I think we should be able to merge even before the backend PR which allows RTL layout.

@susnux
susnuxforce-pushed the feat/31420/add-bidi-support branch from 7e6f6fd to 3543ae0CompareAugust 27, 2024 20:20
@skjnldsv

Copy link
Copy Markdown
Member

Ready for review @susnux ?

@susnux

Copy link
Copy Markdown
Contributor

Ready for review ?

Yes I think so

@susnux
susnux marked this pull request as ready for review August 28, 2024 12:20
@susnux
susnux requested review from ShGKme and artongeAugust 28, 2024 12:21
@nickvergessen
nickvergessen removed their request for review August 28, 2024 12:51
@AndyScherzingerAndyScherzinger added this to the Nextcloud 31 milestone Aug 28, 2024
@skjnldsv

Copy link
Copy Markdown
Member

/compile amend-rebase /

ahangarhaand others added 7 commits August 29, 2024 08:32
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
Fix other background-positions
Minor fix in link button icon position
Update header left and right to start and end
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-commandforce-pushed the feat/31420/add-bidi-support branch from 3543ae0 to faeb2f0CompareAugust 29, 2024 08:35
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 29, 2024
@skjnldsv
skjnldsv merged commit 292a306 into masterAug 29, 2024
@skjnldsv
skjnldsv deleted the feat/31420/add-bidi-support branch August 29, 2024 08:56
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: language/translations (l10n/i18n)Localization and translation matters🍀 2025-Spring

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants

@AndyScherzinger@skjnldsv@nickvergessen@susnux@ahangarha