Uh oh!
There was an error while loading. Please reload this page.
Use logical positioning instead of physical for bidirectional text support - #47343
Conversation
Files potentially missing some code change from previous PR:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
6583062 to
655d89bComparenickvergessen
commented
Aug 20, 2024
Backend part moved to #47349 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
6e73d75 to
55dd692Compare
susnux
left a comment
There was a problem hiding this comment.
Test seems to work fine, but some comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
4527b31 to
b789d58Compareb789d58 to
c490feaCompare7ccea6d to
7e6f6fdCompare
susnux
left a comment
There was a problem hiding this comment.
Tested it, could not find any regressions with LTR language.
So I think we should be able to merge even before the backend PR which allows RTL layout.
7e6f6fd to
3543ae0Compareskjnldsv
commented
Aug 28, 2024
Ready for review @susnux ? |
susnux
commented
Aug 28, 2024
Yes I think so |
skjnldsv
commented
Aug 29, 2024
/compile amend-rebase / |
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
Fix other background-positions Minor fix in link button icon position Update header left and right to start and end Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
3543ae0 to
faeb2f0Compare
Summary
This PR is the first step towards adding bidirectional text support to the Nextcloud ecosystem. It affects the entire project; accordingly, each app should have subsequent PRs.
The PR is 90+ percent complete. I decided to make the PR to
I had challenges in building the project. Generating
cssfiles and thedistdirectory during development is something I am uncomfortable with.Because of supporting Samsung Internet, I needed to take some hacky approach.
Note:
We must update many components in NextCloud/vue. The most important one was the
header-menuvue component which is already updated. Others will come soon. First, I need to ensure this PR is getting prepared for merge.Screenshots
TODO
.rightor.menu-left.core/css/tooltip.scssand its right|left classesdirattribute on the body. (help needed)Checklist