Skip to content

Add bidirectional text support - Backend - #47349

Merged
nickvergessen merged 5 commits into
masterfrom
feat/31420/bidi-backend-support
Sep 24, 2024
Merged

Add bidirectional text support - Backend#47349
nickvergessen merged 5 commits into
masterfrom
feat/31420/bidi-backend-support

Conversation

@nickvergessen

@nickvergessennickvergessen commented Aug 20, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Checklist

@nickvergessennickvergessen added this to the Nextcloud 31 milestone Aug 20, 2024
@nickvergessennickvergessen changed the title Feat/31420/bidi backend supportWIP - Add bidirectional text support - BackendAug 20, 2024
@nickvergessennickvergessen mentioned this pull request Aug 20, 2024
Merged
8 tasks
susnux
susnux reviewed Aug 20, 2024
View reviewed changes
Comment threadlib/public/L10N/IFactory.php Outdated
@susnuxsusnux added enhancement 2. developing Work in progress feature: language/translations (l10n/i18n) Localization and translation matters labels Aug 20, 2024
susnux
susnux reviewed Aug 20, 2024
View reviewed changes
Comment threadlib/private/L10N/Factory.php Outdated
@nickvergessen
nickvergessenforce-pushed the feat/31420/bidi-backend-support branch from 08ff13d to ad9d7dcCompareAugust 20, 2024 14:33
icewind1991
icewind1991 previously approved these changes Aug 20, 2024
View reviewed changes
@susnuxsusnux changed the title WIP - Add bidirectional text support - BackendAdd bidirectional text support - BackendAug 20, 2024
@susnuxsusnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 20, 2024
@susnux
susnux requested review from a team, provokateurin, skjnldsv and yemkareems and removed request for a teamAugust 20, 2024 16:29
provokateurin
provokateurin previously approved these changes Aug 20, 2024
View reviewed changes
susnux
susnux reviewed Aug 20, 2024
View reviewed changes
Comment threadlib/private/L10N/Factory.php Outdated
susnux
susnux reviewed Aug 20, 2024
View reviewed changes
Comment threadlib/private/L10N/Factory.php Outdated
susnux
susnux reviewed Aug 20, 2024
View reviewed changes
Comment threadlib/private/L10N/Factory.php Outdated
skjnldsv
skjnldsv previously approved these changes Aug 20, 2024
View reviewed changes
@nickvergessen
nickvergessen removed the request for review from yemkareemsAugust 20, 2024 21:44
@nickvergessennickvergessen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 20, 2024
@nickvergessen
nickvergessen marked this pull request as draft August 20, 2024 21:50
@nickvergessen
nickvergessenforce-pushed the feat/31420/bidi-backend-support branch from d3094e8 to a22001aCompareSeptember 18, 2024 09:04
ghorbani-aliand others added 5 commits September 23, 2024 16:59
@ghorbani-ali@nickvergessen
feat(rtl): Set layout direction based on language
2b7efd6
Signed-off-by: ali ghorbani <ghorbani.ali.developer@gmail.com>
@ahangarha@nickvergessen
fix(rtl): Add unittest for language direction
d947452
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
@nickvergessen
fix(rtl): Fix list of RTL languages
ae06ab5
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
ci: Restrict RTL characters to RTL languages
242f89a
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(rtl): Make clear that the direction is based on language
82566c5
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the feat/31420/bidi-backend-support branch from b020d9e to 82566c5CompareSeptember 23, 2024 15:00
@nickvergessennickvergessen mentioned this pull request Sep 23, 2024
Closed
@nickvergessen
nickvergessen marked this pull request as ready for review September 23, 2024 15:05
@nickvergessennickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 23, 2024
@nickvergessen
nickvergessen merged commit 12ed773 into masterSep 24, 2024
@nickvergessen
nickvergessen deleted the feat/31420/bidi-backend-support branch September 24, 2024 09:27
@nickvergessen

nickvergessen commented Sep 24, 2024

Copy link
Copy Markdown
MemberAuthor

/backport 242f89a to stable30

@nickvergessen

nickvergessen commented Sep 24, 2024

Copy link
Copy Markdown
MemberAuthor

/backport 242f89a to stable29

@nickvergessen

nickvergessen commented Sep 24, 2024

Copy link
Copy Markdown
MemberAuthor

/backport 242f89a to stable28

@backportbotbackportbotBot mentioned this pull request Sep 24, 2024
Merged
1 task
This was referenced Sep 24, 2024
Merged
Merged
susnux
susnux reviewed Sep 25, 2024
View reviewed changes
Comment threadbuild/translation-checker.php
'ps', // Pashto,
'ug', // 'Uyghurche / Uyghur
'ur_PK', // Urdu
'uz', // Uzbek Afghan

@susnuxsusnuxSep 25, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is wrong Uzbek is written in Latin script (LTR) only afghan Uzbek is RTL (uz_AF)

@AndyScherzingerAndyScherzingerSep 25, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR welcome 😉

@nickvergessennickvergessenSep 27, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#48419

@AndyScherzinger

AndyScherzinger commented Sep 26, 2024

Copy link
Copy Markdown
Member

@ahangarha so the changes you made with some work on top by further engineers has been merged, so main branch now ships all the changes so far.

From here on the long list of small fixes will start I think and any PR can just target the master branch. Any discussion can happen on the Talk room as aligned some weeks ago.

Hope you are good and I think we are all happy with the current progress already, so let's take it from here and improve all the bits and pieces on bi-directional text support 🚀

@ahangarha

ahangarha commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

Great Job 👍🏾

This was referenced Oct 1, 2024
Closed
Closed
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzingerAndyScherzingerAndyScherzinger approved these changes
@susnuxsusnuxsusnux left review comments
@skjnldsvskjnldsvskjnldsv approved these changes
@icewind1991icewind1991icewind1991 left review comments
@provokateurinprovokateurinprovokateurin left review comments

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsenhancementfeature: language/translations (l10n/i18n)Localization and translation matters🍀 2025-Spring

Projects

📁 Files team
Archived in project

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

8 participants

@nickvergessen@skjnldsv@AndyScherzinger@ahangarha@icewind1991@susnux@provokateurin@ghorbani-ali