Uh oh!
There was an error while loading. Please reload this page.
[stable29] fix(files): Reset drop notice on firefox - #47497
Merged
Conversation
susnuxforce-pushed
the
backport/47465/stable29
branch
from
August 26, 2024 23:50
7cb9687 to
88dc777Comparesusnux
approved these changes
Aug 26, 2024
susnux
commented
Aug 26, 2024
Contributor
/compile |
susnux
marked this pull request as ready for review
August 26, 2024 23:51
skjnldsv
approved these changes
Aug 27, 2024
On firefox there is an old bug where when you move a dragged file outside the window the `dragleave` event is never emitted. So we just use a timeout to reset the drag over state. Also a small change: Use the ID of the main container instead of relying on tag name and class. (The ID is guranteed as other APIs rely on it, while the class is just used internally). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
backport/47465/stable29
branch
from
August 27, 2024 09:58
3f78722 to
8fb9c82Comparesusnux
commented
Aug 27, 2024
Contributor
/compile |
susnux
enabled auto-merge
August 27, 2024 09:58
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #47465
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.