Uh oh!
There was an error while loading. Please reload this page.
fix(files): Reset drop notice on firefox - #47465
Conversation
susnux
commented
Aug 24, 2024
Firefox bugs that cause this:
And yes those are open since Firefox 4(!) |
susnux
commented
Aug 24, 2024
/backport to stable30 |
susnux
commented
Aug 24, 2024
/backport to stable29 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
7ef9bb6 to
f3a2d3bComparef3a2d3b to
98d5d86Comparesusnux
commented
Aug 26, 2024
/compile |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
BTW not sure if this has side effects, but to prevent them if they exist I do not like |
506deec to
a86ce67Comparesusnux
commented
Aug 26, 2024
/compile amend/ |
a86ce67 to
b1017b4CompareOn firefox there is an old bug where when you move a dragged file outside the window the `dragleave` event is never emitted. So we just use a timeout to reset the drag over state. Also a small change: Use the ID of the main container instead of relying on tag name and class. (The ID is guranteed as other APIs rely on it, while the class is just used internally). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
b1017b4 to
744b41bCompareskjnldsv
commented
Aug 30, 2024
/backport to stable28 |
Summary
On Firefox there is an old bug where when you move a dragged file outside the window the
dragleaveevent is never emitted. So we just use a timeout to reset the drag over state.Also a small change: Use the ID of the main container instead of relying on tag name and class. (The ID is guaranteed as other APIs rely on it, while the class is just used internally).
Screen recording
This is how the bug looks (before this PR):
Bildschirmaufnahme_20240824_120143.webm
Checklist