Skip to content

[stable28] fix(files): Reset drop notice on firefox - #47639

Merged
susnux merged 3 commits into
stable28from
backport/47465/stable28
Aug 31, 2024
Merged

[stable28] fix(files): Reset drop notice on firefox#47639
susnux merged 3 commits into
stable28from
backport/47465/stable28

Conversation

@backportbot

@backportbotbackportbotBot commented Aug 30, 2024

Copy link
Copy Markdown

Backport of #47465
Fix#47268

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

susnuxand others added 2 commits August 30, 2024 13:45
On firefox there is an old bug where when you move a dragged file outside
the window the `dragleave` event is never emitted.
So we just use a timeout to reset the drag over state.
Also a small change: Use the ID of the main container instead of relying on tag name and class.
(The ID is guranteed as other APIs rely on it, while the class is just used internally).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@backportbotbackportbotBot added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: files labels Aug 30, 2024
@backportbotbackportbotBot added this to the Nextcloud 28.0.10 milestone Aug 30, 2024
Comment threadapps/files/src/components/DragAndDropNotice.vue
@skjnldsv

Copy link
Copy Markdown
Member

/compile amend /

@skjnldsv
skjnldsv marked this pull request as ready for review August 30, 2024 13:48
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnux merged commit 25fbb9d into stable28Aug 31, 2024
@susnux
susnux deleted the backport/47465/stable28 branch August 31, 2024 16:17
@blizzzblizzz mentioned this pull request Sep 4, 2024
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.feature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@susnux@nextcloud-command