Uh oh!
There was an error while loading. Please reload this page.
[stable28] fix: Use sha256 to hash arguments of background jobs - #47776
Merged
Conversation
This is to prevent collision as we are sometime hashing user input, yet using that hash to target the background job in the database. Signed-off-by: Louis Chemineau <louis@chmn.me>
backportbotBot
requested review from
AndyScherzinger, artonge, provokateurin and sorbaughSeptember 5, 2024 15:56
artongeforce-pushed
the
backport/47769/stable28
branch
2 times, most recently
from
September 5, 2024 16:08
204d75b to
ba25dafCompareartonge
approved these changes
Sep 5, 2024
artonge
marked this pull request as ready for review
September 5, 2024 16:09
Signed-off-by: Louis Chemineau <louis@chmn.me>
artongeforce-pushed
the
backport/47769/stable28
branch
from
September 5, 2024 16:09
ba25daf to
7f742cbCompareAndyScherzinger
approved these changes
Sep 5, 2024
blizzz
previously requested changes
Sep 5, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Member
test failed three times, but cannot be relevant to the changes update: actually twice and different → merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #47769
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.