Uh oh!
There was an error while loading. Please reload this page.
fix: Use sha256 to hash arguments of background jobs - #47769
Merged
sorbaugh merged 2 commits intoSep 5, 2024
Conversation
artonge
commented
Sep 5, 2024
CollaboratorAuthor
/backport to stable30 |
artonge
commented
Sep 5, 2024
CollaboratorAuthor
/backport to stable29 |
artonge
commented
Sep 5, 2024
CollaboratorAuthor
/backport to stable28 |
artongeforce-pushed
the
artonge/fix/use_sha256_for_arguments_hash_forbg_jobs
branch
from
September 5, 2024 11:41
b09b8d1 to
0460f00Comparesorbaugh
approved these changes
Sep 5, 2024
provokateurin
approved these changes
Sep 5, 2024
artongeforce-pushed
the
artonge/fix/use_sha256_for_arguments_hash_forbg_jobs
branch
from
September 5, 2024 12:46
0460f00 to
dc2d4d6CompareThis is to prevent collision as we are sometime hashing user input, yet using that hash to target the background job in the database. Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artongeforce-pushed
the
artonge/fix/use_sha256_for_arguments_hash_forbg_jobs
branch
from
September 5, 2024 13:37
dc2d4d6 to
dbf56b6CompareAndyScherzinger
approved these changes
Sep 5, 2024
sorbaugh
deleted the
artonge/fix/use_sha256_for_arguments_hash_forbg_jobs
branch
September 5, 2024 15:53
This was referenced Sep 5, 2024
kesselb added a commit
that referenced
this pull request
Sep 12, 2024
Follow-up for #47769 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
5 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we are using this hash as ID, it makes it more reliable than the current md5 hash we are using.