Skip to content

[stable29] fix: Use sha256 to hash arguments of background jobs - #47777

Merged
blizzz merged 3 commits into
stable29from
backport/47769/stable29
Sep 5, 2024
Merged

[stable29] fix: Use sha256 to hash arguments of background jobs#47777
blizzz merged 3 commits into
stable29from
backport/47769/stable29

Conversation

@backportbot

Copy link
Copy Markdown

Backport of PR #47769

This is to prevent collision as we are sometime hashing user input, yet using that hash to target the background job in the database.
Signed-off-by: Louis Chemineau <louis@chmn.me>
@backportbotbackportbotBot added enhancement 3. to review Waiting for reviews php Pull requests that update Php code labels Sep 5, 2024
@backportbotbackportbotBot added this to the Nextcloud 29.0.7 milestone Sep 5, 2024
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
artongeforce-pushed the backport/47769/stable29 branch from cfe5494 to 8552ac4CompareSeptember 5, 2024 16:06
Comment threadcore/Migrations/Version28000Date20240828142927.php Fixed
blizzz
blizzz previously requested changes Sep 5, 2024

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psalm found a missing import

Comment threadcore/Migrations/Version28000Date20240828142927.php Fixed
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzz merged commit 3c9abb0 into stable29Sep 5, 2024
@blizzz
blizzz deleted the backport/47769/stable29 branch September 5, 2024 19:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancementphpPull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@AndyScherzinger@blizzz@artonge@github-advanced-security