Uh oh!
There was an error while loading. Please reload this page.
[stable28] fix(dav): Always respond custom error page on exceptions - #47785
Merged
Conversation
backportbotBot
requested review from
AndyScherzinger, artonge and provokateurinSeptember 5, 2024 18:14
artongeforce-pushed
the
backport/47770/stable28
branch
from
September 5, 2024 18:35
26df2fe to
d25d8ccCompareartonge
approved these changes
Sep 5, 2024
AndyScherzinger
approved these changes
Sep 5, 2024
| } else { | ||
| $templateName = 'xml_exception'; | ||
| $renderAs = null; | ||
| $this->server->httpResponse->setHeader('Content-Type', 'application/xml; charset=utf-8'); |
Check notice
Code scanning / Psalm
PossiblyNullPropertyFetch
| } else { | ||
| $templateName = 'xml_exception'; | ||
| $renderAs = null; | ||
| $this->server->httpResponse->setHeader('Content-Type', 'application/xml; charset=utf-8'); |
Check notice
Code scanning / Psalm
PossiblyNullReference
| $content = new OC_Template('core', $templateName, 'guest'); | ||
| $debug = $this->config->getSystemValueBool('debug', false); | ||
| $content = new OC_Template('core', $templateName, $renderAs); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
| if (BrowserErrorPagePlugin::isBrowserRequest($request)) { | ||
| $this->server->addPlugin(new BrowserErrorPagePlugin()); | ||
| } | ||
| $this->server->addPlugin(new ErrorPagePlugin($this->request, \OC::$server->getConfig())); |
Check notice
Code scanning / Psalm
DeprecatedMethod
artonge
marked this pull request as ready for review
September 5, 2024 20:44
artonge
enabled auto-merge
September 5, 2024 20:44
susnux
requested changes
Sep 7, 2024
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Louis Chemineau <louis@chmn.me>
The `<?xml` tag is interpreted as PHP short tags, so this causes errors. Instead just print that part of the template. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
artongeforce-pushed
the
backport/47770/stable28
branch
from
September 9, 2024 15:30
785582a to
414a66eComparesorbaugh
disabled auto-merge
September 10, 2024 08:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #47770
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.