Uh oh!
There was an error while loading. Please reload this page.
fix: Replace conflicting tags in xml_exception template - #47805
Merged
Conversation
susnux
requested review from
a team, ArtificialOwl, artonge and sorbaugh
and removed request for
a teamSeptember 6, 2024 14:51
provokateurin
approved these changes
Sep 6, 2024
susnuxforce-pushed
the
fix/xml-exception-template
branch
from
September 6, 2024 15:14
6a738b1 to
e5745d7Comparesusnux
commented
Sep 7, 2024
ContributorAuthor
/backport to stable29 |
susnux
commented
Sep 7, 2024
ContributorAuthor
/backport to stable30 |
2 tasks
artonge
approved these changes
Sep 9, 2024
Antreesy
approved these changes
Sep 9, 2024
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Just stumbled on it, when tried to upload files via Talk (failed on PROPFIND request)
Tested, works with this change
The `<?xml` tag is interpreted as PHP short tags, so this causes errors. Instead just print that part of the template. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/xml-exception-template
branch
from
September 9, 2024 11:27
923850b to
6198138Comparesusnux
enabled auto-merge
September 9, 2024 11:27
This was referenced Sep 9, 2024
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
<?xmltag is interpreted as PHP short tags, so this causes errors. Instead just print that part of the template.Checklist