Uh oh!
There was an error while loading. Please reload this page.
fix(files): Ensure children are removed from folder and not duplicated - #47905
Merged
Conversation
susnux
requested review from
a team and artonge
and removed request for
a teamSeptember 11, 2024 18:17
susnux
commented
Sep 11, 2024
ContributorAuthor
/backport to stable30 |
susnux
commented
Sep 11, 2024
ContributorAuthor
/backport to stable29 |
skjnldsv
approved these changes
Sep 14, 2024
skjnldsvforce-pushed
the
fix/files-duplicated-nodes
branch
from
September 14, 2024 19:17
625a545 to
e2ffa0aCompare* Resolves#47904 We need to make sure that we only add one source (unique!) once as a child, this is ensured by simply use a native `Set`. Also we need to remove children on from folders when the `files:node:deleted` event is emitted. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/files-duplicated-nodes
branch
from
September 20, 2024 09:09
1ac295f to
f02bcf3Comparesusnux
commented
Sep 20, 2024
ContributorAuthor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nfebe
approved these changes
Sep 20, 2024
This was referenced Sep 20, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We need to make sure that we only add one source (unique!) once as a child, this is ensured by simply use a native
Set.Also we need to remove children on from folders when the
files:node:deletedevent is emitted.Checklist