Skip to content

[stable30] fix(files): Ensure children are removed from folder and not duplicated - #48240

Merged
susnux merged 2 commits into
stable30from
backport/47905/stable30
Oct 17, 2024
Merged

[stable30] fix(files): Ensure children are removed from folder and not duplicated#48240
susnux merged 2 commits into
stable30from
backport/47905/stable30

Conversation

@backportbot

@backportbotbackportbotBot commented Sep 20, 2024

Copy link
Copy Markdown

Backport of #47905

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbotbackportbotBot added the 3. to review Waiting for reviews label Sep 20, 2024
@backportbotbackportbotBot added this to the Nextcloud 30.0.1 milestone Sep 20, 2024
@susnux
susnuxforce-pushed the backport/47905/stable30 branch from fcb516e to 90d3e3fCompareOctober 15, 2024 14:55
@susnux
susnux marked this pull request as ready for review October 15, 2024 14:56
@susnux
susnux requested a review from artongeOctober 15, 2024 14:56
* Resolves#47904
We need to make sure that we only add one source (unique!) once as a child,
this is ensured by simply use a native `Set`.
Also we need to remove children on from folders when the `files:node:deleted`
event is emitted.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the backport/47905/stable30 branch from 90d3e3f to 914de0eCompareOctober 17, 2024 14:26
@susnux

Copy link
Copy Markdown
Contributor

/compile

@susnux
susnux enabled auto-merge October 17, 2024 14:26
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the backport/47905/stable30 branch from 95366a8 to 7b78a64CompareOctober 17, 2024 15:54
@susnux
susnux merged commit 50d4656 into stable30Oct 17, 2024
@susnux
susnux deleted the backport/47905/stable30 branch October 17, 2024 16:36
@AltahrimAltahrim mentioned this pull request Oct 30, 2024
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@susnux@artonge@blizzz