Uh oh!
There was an error while loading. Please reload this page.
build: bump version to run sha256 for background job arguments migration - #47930
Merged
Conversation
Follow-up for #47769 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
requested review from
Altahrim and sorbaugh
and removed request for
a teamSeptember 12, 2024 15:59
AndyScherzinger
approved these changes
Sep 12, 2024
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
commented
Sep 12, 2024
ContributorAuthor
I pushed another commit to bump the 3rdparty version and fix the check "Block merging with outdated 3rdparty". |
susnux
approved these changes
Sep 12, 2024
susnux
reviewed
Sep 12, 2024
ContributorAuthor
There was a problem hiding this comment.
It's unrelated, but without the required check for 3rdparty is failing.
If you prefer, I drop the commit and send another pr.
There was a problem hiding this comment.
Merged, done is better than perfect (PRs)
AndyScherzinger
commented
Sep 12, 2024
Member
@artonge is this a must merge for v30.0.0? |
susnux
commented
Sep 12, 2024
Contributor
The version is bumped during the RC creation by the release team, so this should be good for all stable branches. |
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up for #47769
TODO
Checklist