Skip to content

fix: Remove OCP\Files\Storage interface deprecated since version 9 - #48009

Merged
come-nc merged 9 commits into
masterfrom
fix/remove-references-to-deprected-storage-interface
Sep 16, 2024
Merged

fix: Remove OCP\Files\Storage interface deprecated since version 9#48009
come-nc merged 9 commits into
masterfrom
fix/remove-references-to-deprected-storage-interface

Conversation

@come-nc

@come-nccome-nc commented Sep 15, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

Remove deprecated interface and its last uses (mostly in tests).

Checklist

@come-nccome-nc added the 2. developing Work in progress label Sep 15, 2024
@come-nccome-nc self-assigned this Sep 15, 2024
github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 15, 2024
View reviewed changes
Comment threadapps/files_external/lib/Config/ConfigAdapter.php Fixed
Comment threadapps/files_external/lib/Lib/Auth/Password/SessionCredentials.php Fixed
@come-nc
come-ncforce-pushed the fix/remove-references-to-deprected-storage-interface branch 2 times, most recently from 95bdfaf to 619767aCompareSeptember 15, 2024 12:39
github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 15, 2024
View reviewed changes
Comment threadapps/files_trashbin/lib/Trashbin.php Fixed
@come-nccome-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 15, 2024
@skjnldsvskjnldsv added the technical debt 🧱 🤔🚀 label Sep 16, 2024
icewind1991
icewind1991 reviewed Sep 16, 2024
View reviewed changes
Comment threadlib/private/Files/Storage/Common.php
icewind1991
icewind1991 reviewed Sep 16, 2024
View reviewed changes
Comment threadlib/public/Files/Storage/IStorage.php Outdated
Comment threadlib/public/Files/Storage/IStorage.php
@come-nc
fix: Remove OCP\Files\Storage interface deprecated since version 9
801733e
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Fix other uses of removed Storage interface
22822d5
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore: Fix encryption test use statement
a165d8f
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore: fix autoloaders
f80eda4
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore: Fix psalm issues, put back private versions of getter in priva…
492e699
…te Storage interface
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore: psalm-suppress legacy code weirdness
5d01e0a
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore: Remove deprecated Storage::search method instead of moving it …
ed0ac28
…to IStorage
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore: Check storage is an instance of the correct class instead of p…
e7ac9bb
…salm-suppress
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
come-ncforce-pushed the fix/remove-references-to-deprected-storage-interface branch from f9cd67f to e7ac9bbCompareSeptember 16, 2024 16:11
@come-nccome-nc mentioned this pull request Sep 16, 2024
Merged
4 tasks
susnux
susnux reviewed Sep 16, 2024
View reviewed changes
Comment threadapps/dav/tests/unit/Connector/Sabre/FileTest.php Outdated
@come-nc
chore: Improve typing and phpdoc comments
03b969f
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nccome-nc added the pending documentation This pull request needs an associated documentation update label Sep 16, 2024
@provokateurinprovokateurin mentioned this pull request Sep 16, 2024
Merged
4 tasks
@come-nc
come-nc merged commit b9fb1db into masterSep 16, 2024
@come-nc
come-nc deleted the fix/remove-references-to-deprected-storage-interface branch September 16, 2024 18:50
@JulienFS

JulienFS commented Oct 9, 2024

Copy link
Copy Markdown

Thank you so much ! It's been super hard to dive into the code because of the amount of legacy stuff. I'm glad this part is gone 🥳

@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
@come-nccome-nc added this to the Nextcloud 31 milestone Apr 3, 2025
@come-nccome-nc mentioned this pull request Apr 3, 2025
Merged
@come-nccome-nc removed the pending documentation This pull request needs an associated documentation update label Apr 3, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991icewind1991icewind1991 left review comments
@susnuxsusnuxsusnux approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes

Assignees

@come-nccome-nc

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

6 participants

@come-nc@JulienFS@icewind1991@susnux@skjnldsv@github-advanced-security