Uh oh!
There was an error while loading. Please reload this page.
fix(Storage): Document getOwner() can return false - #48094
Merged
Conversation
provokateurin
requested review from
a team, Altahrim, come-nc and yemkareems
and removed request for
a teamSeptember 16, 2024 14:02
provokateurin
commented
Sep 16, 2024
MemberAuthor
/backport to stable30 |
provokateurin
commented
Sep 16, 2024
MemberAuthor
/backport to stable29 |
provokateurin
commented
Sep 16, 2024
MemberAuthor
/backport to stable28 |
provokateurin
commented
Sep 16, 2024
MemberAuthor
Will do! |
provokateurin
marked this pull request as draft
September 16, 2024 18:36
come-nc
commented
Sep 16, 2024
Contributor
Was merged, got you a few conflicts. |
provokateurinforce-pushed
the
fix/storage/get-owner-false
branch
from
September 16, 2024 19:12
74ad1fd to
c99fdf9Compareprovokateurin
marked this pull request as ready for review
September 16, 2024 19:12
provokateurin
commented
Sep 16, 2024
MemberAuthor
Failure probably related :/ |
provokateurinforce-pushed
the
fix/storage/get-owner-false
branch
from
September 17, 2024 08:03
c99fdf9 to
7091b80CompareSigned-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurinforce-pushed
the
fix/storage/get-owner-false
branch
from
September 17, 2024 08:10
7091b80 to
dc13f9cCompareskjnldsv
approved these changes
Sep 17, 2024
This was referenced Sep 17, 2024
2 tasks
This was referenced Sep 18, 2024
Merged
This was referenced Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The return type of getOwner() was never specified, but all implementations already treat it as
string|false.Checklist