Uh oh!
There was an error while loading. Please reload this page.
fix(files): Ensure renaming state is correctly reset - #48425
Merged
Conversation
susnux
commented
Sep 27, 2024
ContributorAuthor
/backport to stable30 |
susnux
marked this pull request as ready for review
October 7, 2024 10:56
susnux
requested review from
a team, Pytal, artonge and sorbaugh
and removed request for
a teamOctober 7, 2024 10:57
Pytal
approved these changes
Oct 7, 2024
artonge
approved these changes
Oct 8, 2024
susnux
commented
Oct 8, 2024
ContributorAuthor
/compile |
susnux
enabled auto-merge
October 8, 2024 16:42
skjnldsv
approved these changes
Oct 15, 2024
Problem: Is a node is renamed and the new name is out of the current visible list of nodes the component will be recycled, this means the props will change, so when the `onRename` functions is about to reset the state the `this.source` will point to a different node. To fix this, but also to separate business logic from visual representation, the logic is moved into the renaming store and the component is only responsible for rendering. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
commented
Oct 15, 2024
ContributorAuthor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2 tasks
susnux
commented
Oct 18, 2024
ContributorAuthor
/backport to stable29 |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem: Is a node is renamed and the new name is out of the current visible list of nodes the component will be recycled, this means the props will change, so when the
onRenamefunctions is about to reset the state thethis.sourcewill point to a different node.To fix this, but also to separate business logic from visual representation, the logic is moved into the renaming store and the component is only responsible for rendering.
Checklist