Uh oh!
There was an error while loading. Please reload this page.
[stable29] fix(files): Ensure renaming state is correctly reset - #48797
Merged
Conversation
artonge
approved these changes
Oct 21, 2024
susnuxforce-pushed
the
backport/48425/stable29
branch
from
October 28, 2024 14:01
ab0f13d to
0d1c5e3Comparesusnux
marked this pull request as ready for review
October 28, 2024 14:01
susnux
approved these changes
Oct 28, 2024
susnuxforce-pushed
the
backport/48425/stable29
branch
from
October 28, 2024 14:01
0d1c5e3 to
0eb5717Comparesusnux
commented
Oct 28, 2024
Contributor
/compile |
susnuxforce-pushed
the
backport/48425/stable29
branch
from
October 29, 2024 12:20
208f497 to
a82e41fComparesusnux
enabled auto-merge
October 29, 2024 12:20
nextcloud-commandforce-pushed
the
backport/48425/stable29
branch
from
October 30, 2024 08:50
a82e41f to
73ed6efComparesusnuxforce-pushed
the
backport/48425/stable29
branch
2 times, most recently
from
October 30, 2024 12:38
b8ca901 to
caf0d4bComparenextcloud-commandforce-pushed
the
backport/48425/stable29
branch
2 times, most recently
from
October 30, 2024 14:38
a39d401 to
483f0d6Comparesusnuxforce-pushed
the
backport/48425/stable29
branch
2 times, most recently
from
October 30, 2024 18:16
0bd8fcf to
58fb9ebCompareAltahrim
commented
Oct 31, 2024
Collaborator
/compile amend / |
nextcloud-commandforce-pushed
the
backport/48425/stable29
branch
from
October 31, 2024 08:41
58fb9eb to
4e6d314CompareProblem: Is a node is renamed and the new name is out of the current visible list of nodes the component will be recycled, this means the props will change, so when the `onRename` functions is about to reset the state the `this.source` will point to a different node. To fix this, but also to separate business logic from visual representation, the logic is moved into the renaming store and the component is only responsible for rendering. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
backport/48425/stable29
branch
from
November 7, 2024 15:40
4e6d314 to
8588e49CompareTODO: Drop when we support Node 22. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
backport/48425/stable29
branch
from
November 7, 2024 16:37
8588e49 to
ca83966Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #48425
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.