Skip to content

ci: fail psalm when baseline update required - #48466

Merged
kesselb merged 1 commit into
masterfrom
ci/noid/require-up-to-date-psalm-paseline
Sep 30, 2024
Merged

ci: fail psalm when baseline update required#48466
kesselb merged 1 commit into
masterfrom
ci/noid/require-up-to-date-psalm-paseline

Conversation

@kesselb

@kesselbkesselb commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

Summary

Psalm now fails when a baseline update is needed.

TODO

  • CI
  • No warning about invalid sarif file

Checklist

@kesselbkesselb self-assigned this Sep 30, 2024
@kesselbkesselb added the 2. developing Work in progress label Sep 30, 2024
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the ci/noid/require-up-to-date-psalm-paseline branch from e9c0c2f to 077ed74CompareSeptember 30, 2024 16:05
@kesselbkesselb changed the title ci: dont update psalm baselineci: fail psalm when baseline update requiredSep 30, 2024
@kesselbkesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 30, 2024
@kesselbkesselb added this to the Nextcloud 31 milestone Sep 30, 2024

@provokateurinprovokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal but better than nothing 👍

@kesselb
kesselb merged commit 1fff4e1 into masterSep 30, 2024
@kesselb
kesselb deleted the ci/noid/require-up-to-date-psalm-paseline branch September 30, 2024 17:00
@kesselb

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@kesselb

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@kesselb

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kesselb@miaulalala@provokateurin