Skip to content

[stable29] ci: fail psalm when baseline update required - #48471

Merged
kesselb merged 3 commits into
stable29from
backport/48466/stable29
Oct 30, 2024
Merged

[stable29] ci: fail psalm when baseline update required#48471
kesselb merged 3 commits into
stable29from
backport/48466/stable29

Conversation

@backportbot

Copy link
Copy Markdown

Backport of PR #48466

@backportbotbackportbotBot added the 3. to review Waiting for reviews label Sep 30, 2024
@backportbotbackportbotBot added this to the Nextcloud 29.0.8 milestone Sep 30, 2024
@provokateurin

Copy link
Copy Markdown
Member

Meh now we have some diff because of the CDATA stuff which is somehow inconsistent 😢

@kesselb
kesselbforce-pushed the backport/48466/stable29 branch from f26b318 to 7286b35CompareSeptember 30, 2024 21:28
@kesselb

Copy link
Copy Markdown
Contributor

Meh now we have some diff because of the CDATA stuff which is somehow inconsistent

Yep, we need psalm ~5.22 to have a stable psalm baseline: vimeo/psalm#10632

@AltahrimAltahrim mentioned this pull request Oct 1, 2024
1 task
@blizzzblizzz mentioned this pull request Oct 10, 2024
@AltahrimAltahrim mentioned this pull request Oct 30, 2024
4 tasks
@Altahrim

Copy link
Copy Markdown
Collaborator

Conflict with psalm baseline

@kesselb
kesselbforce-pushed the backport/48466/stable29 branch from 3379869 to 2828dd8CompareOctober 30, 2024 14:34
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
To ensure we have a stable baseline
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the backport/48466/stable29 branch from 2828dd8 to c9b0742CompareOctober 30, 2024 14:36
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the backport/48466/stable29 branch from c9b0742 to 8469e1aCompareOctober 30, 2024 14:54
@kesselb

Copy link
Copy Markdown
Contributor

Conflicts resolved.

@kesselb
kesselb merged commit e25f205 into stable29Oct 30, 2024
@kesselb
kesselb deleted the backport/48466/stable29 branch October 30, 2024 16:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@provokateurin@kesselb@Altahrim@miaulalala@blizzz