Skip to content

fix(files_sharing): Add proper user facing messages on success - #48696

Merged
susnux merged 2 commits into
masterfrom
fix/share-notifications
Oct 16, 2024
Merged

fix(files_sharing): Add proper user facing messages on success#48696
susnux merged 2 commits into
masterfrom
fix/share-notifications

Conversation

@susnux

@susnuxsusnux commented Oct 14, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  1. Use proper translated strings
  2. Fix invalid use of translation message on API result
  3. Log all errors

Checklist

@susnuxsusnux added this to the Nextcloud 31 milestone Oct 14, 2024
@susnux

susnux commented Oct 14, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@susnux

susnux commented Oct 14, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

Pytal
Pytal approved these changes Oct 15, 2024
View reviewed changes

@PytalPytal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the message 👍

Comment threadapps/files_sharing/src/mixins/SharesMixin.js Outdated
@susnux
susnuxforce-pushed the fix/share-notifications branch 2 times, most recently from ec4475c to e2c734dCompareOctober 15, 2024 23:19
@susnux

susnux commented Oct 15, 2024

Copy link
Copy Markdown
ContributorAuthor

/compile

@susnux
susnux enabled auto-merge October 15, 2024 23:20
susnuxand others added 2 commits October 16, 2024 12:09
@susnux@Pytal
fix(files_sharing): Add proper user facing messages on success
0ccced8
1. Use proper translated strings
2. Fix invalid use of translation message on API result
3. Log all errors
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@nextcloud-command@susnux
chore(assets): Recompile assets
8e59960
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnuxforce-pushed the fix/share-notifications branch from 5d839fe to 8e59960CompareOctober 16, 2024 10:12
@susnux
susnux merged commit 9692da4 into masterOct 16, 2024
@susnux
susnux deleted the fix/share-notifications branch October 16, 2024 10:49
This was referenced Oct 16, 2024
Merged
Merged
@susnux

susnux commented Oct 18, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@backportbotbackportbotBot mentioned this pull request Oct 18, 2024
Merged
2 tasks
@joshtrichardsjoshtrichards mentioned this pull request Nov 8, 2024
Closed
9 tasks
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
@joshtrichardsjoshtrichards mentioned this pull request Mar 19, 2025
Closed
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IvansssIvansssIvansss approved these changes
@PytalPytalPytal approved these changes
@solracsfsolracsfAwaiting requested review from solracsf

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: sharing

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

[Bug]: Share confirmations messages wrong

4 participants

@susnux@Ivansss@Pytal@nextcloud-command