Skip to content

[stable28] fix(files_sharing): Add proper user facing messages on success - #48796

Merged
susnux merged 2 commits into
stable28from
backport/48696/stable28
Oct 23, 2024
Merged

[stable28] fix(files_sharing): Add proper user facing messages on success#48796
susnux merged 2 commits into
stable28from
backport/48696/stable28

Conversation

@backportbot

@backportbotbackportbotBot commented Oct 18, 2024

Copy link
Copy Markdown

Backport of #48696

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@IvansssIvansss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

1. Use proper translated strings
2. Fix invalid use of translation message on API result
3. Log all errors
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the backport/48696/stable28 branch from 94ad771 to cb96578CompareOctober 23, 2024 11:45
@susnux
susnux marked this pull request as ready for review October 23, 2024 11:45
@susnux

Copy link
Copy Markdown
Contributor

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnux enabled auto-merge October 23, 2024 12:53
@susnux
susnux merged commit 0977b7d into stable28Oct 23, 2024
@susnux
susnux deleted the backport/48696/stable28 branch October 23, 2024 13:24
@AltahrimAltahrim mentioned this pull request Oct 30, 2024
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@susnux@Ivansss@nextcloud-command