Uh oh!
There was an error while loading. Please reload this page.
[stable29] fix: get rid of denied notification when accept - #48752
Merged
Conversation
backportbotBot
requested review from
Antreesy, juliusknorr, nickvergessen and susnuxOctober 17, 2024 06:42
Antreesyforce-pushed
the
backport/48734/stable29
branch
from
October 17, 2024 07:02
12d7f30 to
2c0a16aCompareUh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com> (cherry picked from commit 73b34bb)
Antreesyforce-pushed
the
backport/48734/stable29
branch
from
October 17, 2024 07:06
2c0a16a to
0a21c50Comparenickvergessen
approved these changes
Oct 17, 2024
nickvergessen
marked this pull request as ready for review
October 17, 2024 07:07
- do not create 'denied' notification if bg job exists Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com> (cherry picked from commit 5be7641)
Antreesyforce-pushed
the
backport/48734/stable29
branch
from
October 17, 2024 07:12
0a21c50 to
90573beCompareAntreesy
approved these changes
Oct 17, 2024
| throw new \InvalidArgumentException('Unhandled app'); | ||
| } | ||
| if ($notification->getSubject() !== 'transferownershipRequest') { | ||
| throw new \InvalidArgumentException('Unhandled notification type'); |
Contributor
There was a problem hiding this comment.
Changed from UnknownNotificationException in original PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #48734
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.