Implement ownerless shares by provokateurin · Pull Request #49073 · nextcloud/server

provokateurin · 2024-11-04T11:40:49Z

Summary

Can be tested with nextcloud/groupfolders#3401

~~Tests still need to be written, but other than that this is ready.~~
It doesn't work with files_external yet, but I think that is due to permissions (UI says there is no reshare permission).

I'm surprised how little lines had to be changed in the end, but the challenging part was exploring how this can be implemented and where things needs to be changed and fixed to make it work.

Behavior:

If the owner is deleted the shares will be deleted
If the owner is disabled the shares continue to exist
If the owner loses access (e.g. removed from group that had access to the Groupfolder) the shares will be ~~deleted~~ hidden

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

icewind1991 · 2024-11-04T18:37:18Z

+ $shares = [];
+ foreach ($providers as $provider) {
+ if ($isCoOwner) {
+ foreach ($node->getDirectoryListing() as $childNode) {


This makes it a lot more expensive, can we tweak getSharesInFolder to make the $user filter optional instead?

We can't do this without a breaking change, as it would break provider implementations that don't expect to receive null.
Maybe that is fine though, as long as the providers only do database SELECTs where a null value is fine (but that would still result in unexpected results as nothing would be returned instead of everything).

Istead of null it could receive a keyword.

provokateurin · 2024-11-13T13:46:37Z

Added tests for everything 🎉

ArtificialOwl · 2024-11-20T15:29:01Z

maybe Ownerless instead of CoOwner ?

provokateurin · 2024-11-20T16:35:00Z

Sure I will go with that, even though it is still inaccurate :/

Signed-off-by: provokateurin <kate@provokateurin.de>

…ath() Signed-off-by: provokateurin <kate@provokateurin.de>

… owner Signed-off-by: provokateurin <kate@provokateurin.de>

Signed-off-by: provokateurin <kate@provokateurin.de>

nfebe · 2024-11-25T10:28:37Z

+ *
+ * @since 31.0.0
+ */
+interface IShareOwnerlessMount {


Suggested change
interfaceIShareOwnerlessMount {
interfaceIShareOpenMount {
// interface IShareCollaborativeMount
Might be too far and too large a refactor at this point but just throwing in the idea.

Hm IShareCollaborativeMount doesn't sound too bad. @ArtificialOwl what do you think?

I also already did a rename of everything this morning, so doing it once more is not much work 🙈

nfebe

Cool to the kwargs in action here.

provokateurin · 2024-11-25T13:03:58Z

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

narcisgarcia · 2024-12-03T12:23:38Z

Will this enhancement reach the expected behavior asked in
nextcloud/groupfolders#3456
and
#49619
?

provokateurin added enhancement 2. developing Work in progress labels Nov 4, 2024

provokateurin added this to the Nextcloud 31 milestone Nov 4, 2024

provokateurin marked this pull request as draft November 4, 2024 11:40

provokateurin mentioned this pull request Nov 4, 2024
feat(GroupMountPoint): Implement IShareOwnerlessMount nextcloud/groupfolders#3401
Merged

icewind1991 reviewed Nov 4, 2024
View reviewed changes

provokateurin force-pushed the feat/files_sharing/co-owner branch from dbee0fb to 0ee7f19Compare November 13, 2024 13:45

provokateurin requested review from a team, ArtificialOwl, come-nc and icewind1991 and removed request for a teamNovember 13, 2024 13:45

provokateurin marked this pull request as ready for review November 13, 2024 13:45

provokateurin added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 13, 2024

provokateurin force-pushed the feat/files_sharing/co-owner branch 3 times, most recently from 4c63eba to cd4dc54Compare November 14, 2024 07:16

susnux reviewed Nov 14, 2024
View reviewed changes

Comment threadapps/files_sharing/src/components/SharingEntry.vue Outdated

provokateurin commented Nov 14, 2024
View reviewed changes

Comment threadlib/private/Share20/Manager.php Outdated

ArtificialOwl reviewed Nov 14, 2024
View reviewed changes

Comment threadapps/files_sharing/lib/Controller/ShareAPIController.php Outdated

ArtificialOwl approved these changes Nov 14, 2024
View reviewed changes

feat(Files\Mount): Add IShareOwnerlessMount
ea93dc0
Signed-off-by: provokateurin <kate@provokateurin.de>

provokateurin force-pushed the feat/files_sharing/co-owner branch from cd4dc54 to 5ec57e4Compare November 25, 2024 08:56

provokateurin changed the title ~~Implement share co-owning~~Implement ownerless sharesNov 25, 2024

provokateurin added 2 commits November 25, 2024 10:27

fix(Share20\DefaultShareProvider): Sort getSharesByPath() results
762b090
Signed-off-by: provokateurin <kate@provokateurin.de>

fix(Share20\DefaultShareProvider): Return link shares in getSharesByP…
a978e0a
…ath() Signed-off-by: provokateurin <kate@provokateurin.de>

provokateurin added 2 commits November 25, 2024 10:27

fix(files_sharing,files): Do not validate shares before adjusting the…
715e714
… owner Signed-off-by: provokateurin <kate@provokateurin.de>

fix(SharingEntry): Display owner name if the owner is someone else
c0db746
Signed-off-by: provokateurin <kate@provokateurin.de>

provokateurin force-pushed the feat/files_sharing/co-owner branch from 5ec57e4 to c0db746Compare November 25, 2024 09:27

nextcloud locked and limited conversation to collaborators Nov 25, 2024

nextcloud unlocked this conversation Nov 25, 2024

nfebe reviewed Nov 25, 2024
View reviewed changes

Comment threadapps/files_sharing/lib/Controller/ShareAPIController.php

nfebe reviewed Nov 25, 2024
View reviewed changes

Comment threadlib/public/Share/IManager.php

nfebe reviewed Nov 25, 2024
View reviewed changes

Comment threadlib/public/Share/IManager.php

nfebe approved these changes Nov 25, 2024
View reviewed changes

provokateurin added the pending documentation This pull request needs an associated documentation update label Nov 25, 2024

provokateurin enabled auto-merge November 25, 2024 13:05

chore(assets): Recompile assets
7c3a78a
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

provokateurin merged commit 235b7d7 into masterNov 25, 2024

provokateurin deleted the feat/files_sharing/co-owner branch November 25, 2024 13:41

provokateurin mentioned this pull request Nov 25, 2024
feat(dev): Add OCP\Files\Mount\IShareOwnerlessMount API for 31 nextcloud/documentation#12393
Merged

provokateurin removed the pending documentation This pull request needs an associated documentation update label Nov 25, 2024

This was referenced Dec 3, 2024
Re/sharing group for group sharing management #49619
Closed
Re/sharing group for group sharing management nextcloud/groupfolders#3456
Closed

provokateurin mentioned this pull request Dec 4, 2024
feat(files_external): Enable ownerless shares #49643
Merged
4 tasks

skjnldsv mentioned this pull request Jan 7, 2025
31.0.0 beta 1 #50066
Merged

This was referenced Jan 17, 2025
[stable30] Fix renaming a received share by a user with stale shares #50228
Closed
Add integration tests for renaming a share by a user with stale shares #50229
Open

provokateurin mentioned this pull request Jan 24, 2025
Revert "fix(Share20\Manager): Ensure node is still accessible when checking share" #50389
Merged
4 tasks

provokateurin mentioned this pull request Feb 7, 2025
[Bug]: Group Folder shares within folder lost when original owner is gone from group nextcloud/groupfolders#3591
Closed
8 tasks

provokateurin mentioned this pull request Mar 1, 2025
Cannot modify the user permissions of a shared resource within the same group folder nextcloud/groupfolders#3659
Closed

icewind1991 mentioned this pull request Apr 28, 2025
Performance regression in 31 with co-owner shares #52510
Closed

mgallien mentioned this pull request Jul 31, 2025
[Bug]: Ownerless shares not manageable nextcloud/desktop#8435
Open
8 tasks

	interfaceIShareOwnerlessMount {
	interfaceIShareOpenMount {
	// interface IShareCollaborativeMount

Uh oh!

Uh oh!

Conversation

provokateurin commented Nov 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

icewind1991Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

provokateurinNov 11, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

narcisgarciaDec 3, 2024

Choose a reason for hiding this comment

Uh oh!

provokateurin commented Nov 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ArtificialOwl commented Nov 20, 2024

Uh oh!

provokateurin commented Nov 20, 2024

Uh oh!

Uh oh!

nfebeNov 25, 2024

Choose a reason for hiding this comment

Uh oh!

provokateurinNov 25, 2024

Choose a reason for hiding this comment

Uh oh!

provokateurinNov 25, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nfebe left a comment

Choose a reason for hiding this comment

Uh oh!

provokateurin commented Nov 25, 2024

Uh oh!

narcisgarcia commented Dec 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

provokateurin commented Nov 4, 2024•
edited
Loading

provokateurinNov 11, 2024•
edited
Loading