Uh oh!
There was an error while loading. Please reload this page.
Revert "fix(Share20\Manager): Ensure node is still accessible when checking share" - #50389
Merged
Conversation
provokateurin
commented
Jan 24, 2025
MemberAuthor
/backport to stable31 |
…ecking share" This reverts commit c2ca99e. Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurinforce-pushed
the
revert/share-node-accessible
branch
from
January 24, 2025 08:41
7a1b2c7 to
dcb370aComparesorbaugh
approved these changes
Jan 24, 2025
This was referenced Apr 2, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts part of #49073, as this leads to the FS being setup for everyone when setting it up for a single user.
In principle we still need some kind of check like this one to hide shares where the owner lost access, but I don't know if that is possible in any other way than basically setting up the FS for all users.
Checklist