Skip to content

fix(files): open sidebar on sharing tab by default for files - #49147

Merged
skjnldsv merged 3 commits into
masterfrom
fix/sharing-sidebar-tab-default
Nov 8, 2024
Merged

fix(files): open sidebar on sharing tab by default for files#49147
skjnldsv merged 3 commits into
masterfrom
fix/sharing-sidebar-tab-default

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Nov 8, 2024

Copy link
Copy Markdown
Member

Fix#41567
Will fallback to first tab is app is disabled

@skjnldsvskjnldsv added bug 3. to review Waiting for reviews feature: files regression feature: file sidebar Related to the file sidebar component labels Nov 8, 2024
@skjnldsvskjnldsv added this to the Nextcloud 31 milestone Nov 8, 2024
@skjnldsvskjnldsv self-assigned this Nov 8, 2024
@skjnldsv

This comment was marked as resolved.

@skjnldsv
skjnldsvforce-pushed the fix/sharing-sidebar-tab-default branch from ba7c434 to 661224bCompareNovember 8, 2024 10:12
@skjnldsv
skjnldsv requested a review from nfebeNovember 8, 2024 10:13

@nfebenfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the code that opened the activity tab all the time in the past though? 🤔

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Where is the code that opened the activity tab all the time in the past though? 🤔

nowhere, the activity is just the first tab

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/compile rebase /

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 8, 2024
@skjnldsv
skjnldsv enabled auto-merge November 8, 2024 13:38
@susnux

Copy link
Copy Markdown
Contributor

/backport to stable30

@susnux

Copy link
Copy Markdown
Contributor

/backport to stable29

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Alright, a slight change.
Seems like sharing was expected for both folder and files (legacy)

I'll raise that question on the linked ticket for the design team.
in the meantime, this fixes a few things, so let's get this in

@skjnldsv
skjnldsvforce-pushed the fix/sharing-sidebar-tab-default branch 3 times, most recently from ed2a5d6 to 5c40c51CompareNovember 8, 2024 15:28
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the fix/sharing-sidebar-tab-default branch from 5c40c51 to d432feaCompareNovember 8, 2024 15:44
@skjnldsv
skjnldsv merged commit c870608 into masterNov 8, 2024
@skjnldsv
skjnldsv deleted the fix/sharing-sidebar-tab-default branch November 8, 2024 16:00
@backportbot

Copy link
Copy Markdown

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/49147/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 191e839a f29697a7 d432fea3
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49147/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: file sidebarRelated to the file sidebar componentfeature: filesregression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Versions tab is opened by default when following a …/f/{fileId} link or clicking on the right end of the files list

3 participants

@skjnldsv@susnux@nfebe