Uh oh!
There was an error while loading. Please reload this page.
fix(files_sharing): Stop overwriting the share expiration date with the default expiration date - #50192
Merged
susnux merged 4 commits intoJan 15, 2025
Conversation
provokateurin
requested review from
a team, nfebe, skjnldsv and szaimen
and removed request for
a teamJanuary 15, 2025 09:43
provokateurin
commented
Jan 15, 2025
MemberAuthor
/backport to stable30 |
provokateurin
commented
Jan 15, 2025
MemberAuthor
/backport to stable29 |
provokateurin
commented
Jan 15, 2025
MemberAuthor
/backport to stable28 |
skjnldsv
approved these changes
Jan 15, 2025
provokateurin
commented
Jan 15, 2025
MemberAuthor
/compile |
provokateurin
enabled auto-merge
January 15, 2025 10:19
provokateurin
disabled auto-merge
January 15, 2025 10:22
provokateurin
marked this pull request as draft
January 15, 2025 10:27
provokateurin
commented
Jan 15, 2025
MemberAuthor
Draft until test is added. |
provokateurin
commented
Jan 15, 2025
MemberAuthor
Watch out when backporting to stable28, I saw that there are duplicate |
…he default expiration date Signed-off-by: provokateurin <kate@provokateurin.de>
This should be done as soon as changed, as the value is not passed to API but needs to be tracked internally (e.g. if you quickly press "save"). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/files_sharing/sharing-entry-link-override-expiration-date
branch
from
January 15, 2025 14:48
b976221 to
b55c337Comparesusnux
marked this pull request as ready for review
January 15, 2025 14:48
susnux
commented
Jan 15, 2025
Contributor
Tests added, needed to fix another bug otherwise test would fail. |
susnuxforce-pushed
the
fix/files_sharing/sharing-entry-link-override-expiration-date
branch
from
January 15, 2025 14:58
b55c337 to
6ef6610CompareSigned-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnuxforce-pushed
the
fix/files_sharing/sharing-entry-link-override-expiration-date
branch
from
January 15, 2025 15:10
6ef6610 to
ddd70c9Comparesusnux
deleted the
fix/files_sharing/sharing-entry-link-override-expiration-date
branch
January 15, 2025 17:00
This was referenced Jan 15, 2025
Merged
8 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If the admin has a default expiration date configured the share expiration date is overwritten every time, even if a different expiration date was selected for the share.
Removing this doesn't cause any problems when creating a new share with the default expiration date, since the date is added in the backend automatically.
Introduced in #49115 and slightly adjusted in #49147.
Checklist