Skip to content

fix(files_sharing): Stop infinite loop blocking link share requests - #49442

Merged
nfebe merged 2 commits into
masterfrom
fix/no-issue/link-sharing-defaults
Dec 9, 2024
Merged

fix(files_sharing): Stop infinite loop blocking link share requests#49442
nfebe merged 2 commits into
masterfrom
fix/no-issue/link-sharing-defaults

Conversation

@nfebe

@nfebenfebe commented Nov 22, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

  • fix(files_sharing): Stop infinite loop blocking link share requests

     Fixes infinite loop preventing share link creation requests from being sent to the backend.

  • fix: Delete link update code in ShareEntryLink

     Since Nexcloud27, all share edits can only be done from the `SharingDetailsTab` or the `QuickShareSelect` so this concerned component does not need to handle updates.

@nfebe
nfebeforce-pushed the fix/no-issue/link-sharing-defaults branch from a73510b to ea48600CompareDecember 3, 2024 15:38
@nfebe

nfebe commented Dec 5, 2024

Copy link
Copy Markdown
ContributorAuthor

This should resolve : #49678

@nfebe
nfebeforce-pushed the fix/no-issue/link-sharing-defaults branch 3 times, most recently from 1894862 to c2f1a91CompareDecember 5, 2024 22:24
@nfebe

nfebe commented Dec 5, 2024

Copy link
Copy Markdown
ContributorAuthor

/compile

@nfebe
nfebe marked this pull request as ready for review December 5, 2024 22:25
@nfebe
nfebe requested review from Pytal and skjnldsvDecember 5, 2024 22:25
@nfebe
nfebeforce-pushed the fix/no-issue/link-sharing-defaults branch from c2f1a91 to 9361ec6CompareDecember 5, 2024 22:28
@nfebe

nfebe commented Dec 5, 2024•
edited by solracsf
Loading

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@nfebe

nfebe commented Dec 5, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@nfebe
nfebeforce-pushed the fix/no-issue/link-sharing-defaults branch 2 times, most recently from 83cda71 to 8b68f3dCompareDecember 5, 2024 22:47
@nfebe

nfebe commented Dec 5, 2024

Copy link
Copy Markdown
ContributorAuthor

/compile

@nfebenfebe changed the title fix(files_sharing): Resolve race condition blocking link share requestsfix(files_sharing): Stop infinite loop blocking link share requestsDec 5, 2024
@nfebe
nfebeforce-pushed the fix/no-issue/link-sharing-defaults branch from 8b68f3d to 4361649CompareDecember 5, 2024 22:51
@nfebenfebe linked an issue Dec 5, 2024 that may be closed by this pull request
[Bug]: 30.0.3 share link completely broken #49678
Closed
8 tasks
Pytal
Pytal approved these changes Dec 5, 2024
View reviewed changes

@PytalPytal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@Pytal

Pytal commented Dec 5, 2024

Copy link
Copy Markdown
Member

Only see backports for 30 + 28, I guess #49115 should also be on 29?

@Pytal

Pytal commented Dec 5, 2024

Copy link
Copy Markdown
Member

Seems partially fixed but the behaviour is unexpected

When clicking the + button, instead of creating the share like before it opens a menu so you have to click "Add another link" to actually create it
image
image

@nfebe
nfebeforce-pushed the fix/no-issue/link-sharing-defaults branch from 4361649 to e2468dbCompareDecember 6, 2024 01:49
@nfebe

nfebe commented Dec 6, 2024

Copy link
Copy Markdown
ContributorAuthor

Seems partially fixed but the behaviour is unexpected

When clicking the + button, instead of creating the share like before it opens a menu so you have to click "Add another link" to actually create it

Should work now properly for all these cases:

  • Default password set but not enforced, and no default expiration date set.
  • Default password set and enforced, and no default expiration date set.
  • Default expiration date set but not enforced, and default password not set and therefore not enforced.
  • Default expiration date set and enforced, and default password not set and therefore not enforced.
  • Default password set but not enforced, and default expiration date set but not enforced.
  • Default password set but not enforced, and default expiration date set and enforced.
  • Default password set and enforced, and default expiration date set but not enforced.
  • Default password set and enforced, and default expiration date set and enforced.

@nfebe
nfebeforce-pushed the fix/no-issue/link-sharing-defaults branch from e2468db to 6116a63CompareDecember 6, 2024 02:25
@nfebe

nfebe commented Dec 6, 2024

Copy link
Copy Markdown
ContributorAuthor

/compile

@solracsf
solracsf requested a review from PytalDecember 6, 2024 10:55
@solracsf

solracsf commented Dec 6, 2024

Copy link
Copy Markdown
Member

/backport to stable30

@solracsf

solracsf commented Dec 6, 2024

Copy link
Copy Markdown
Member

/backport to stable29

@blizzz

blizzz commented Dec 6, 2024

Copy link
Copy Markdown
Member

/backport to stable28

@nfebe
nfebeforce-pushed the fix/no-issue/link-sharing-defaults branch 7 times, most recently from 35a8d0a to 776e376CompareDecember 9, 2024 00:24
@nfebe

nfebe commented Dec 9, 2024

Copy link
Copy Markdown
ContributorAuthor

/compile

nfebeand others added 2 commits December 9, 2024 01:40
@nfebe
fix(files_sharing): Stop infinite loop blocking link share requests
e7dc141
Fixes infinite loop preventing share link creation requests
from being sent to the backend.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nextcloud-command@nfebe
chore(assets): Recompile assets
290f9da
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe
nfebeforce-pushed the fix/no-issue/link-sharing-defaults branch from 4c74e98 to 290f9daCompareDecember 9, 2024 00:41
@nfebe
nfebe merged commit 6f3ee6b into masterDec 9, 2024
@nfebe
nfebe deleted the fix/no-issue/link-sharing-defaults branch December 9, 2024 00:53
This was referenced Dec 9, 2024
Merged
Merged
Merged
@blizzzblizzz mentioned this pull request Dec 9, 2024
Closed
8 tasks
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sorbaughsorbaughsorbaugh approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@PytalPytalAwaiting requested review from Pytal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: 30.0.3 share link completely broken

6 participants

@nfebe@Pytal@solracsf@blizzz@sorbaugh@nextcloud-command