Uh oh!
There was an error while loading. Please reload this page.
[stable29] fix(files_sharing): Stop infinite loop blocking link share requests - #49723
Merged
Conversation
nfebeforce-pushed
the
backport/49442/stable29
branch
from
December 9, 2024 01:01
13ac8af to
b5dd512Comparenfebe
marked this pull request as ready for review
December 9, 2024 01:01
nfebe
approved these changes
Dec 9, 2024
Prevent silent addition of expiration date to shares. Prevent silent addition for password to shares. Both now have a `shareRequiresReview` check Resolves : #48860 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fixes infinite loop preventing share link creation requests from being sent to the backend. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebeforce-pushed
the
backport/49442/stable29
branch
from
December 9, 2024 01:10
b5dd512 to
3c1f8bdComparesolracsf
commented
Dec 9, 2024
Member
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
sorbaugh
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #49442
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.