Uh oh!
There was an error while loading. Please reload this page.
fix(files): hide move dialog action if destination has no CREATE permission - #50177
Conversation
Antreesy
commented
Jan 14, 2025
/backport to stable30 |
susnux
commented
Jan 14, 2025
Would it be possible to add a quick e2e test for this, so we do not run into regressions? |
Antreesy
commented
Jan 15, 2025
Still can't make it run locally, and don't want to waste CI resources for blind attempts 😔 |
Antreesy
commented
Jan 15, 2025
/compile / |
How so? |
…ission Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
ab6da71 to
b06a876CompareAntreesy
commented
Jan 15, 2025
/compile / |
Need some tweaks to work on Windows + WSL2 + Docker + Cypress |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsv
commented
Jan 15, 2025
Please make sure tests are added as a followup @Antreesy 🙏 |
Antreesy
commented
Jan 17, 2025
/backport b06a876 to stable29 |
Summary
'MOVE' action requires both 'CREATE'+'DELETE' permission, therefore it should be hidden for non-writable directories. Currently action fails.
Alternative: disable button (with the same logic)
Checklist