Skip to content

fix(files): hide move dialog action if destination has no CREATE permission - #50177

Merged
Antreesy merged 2 commits into
masterfrom
fix/45982/hide-move-action
Jan 15, 2025
Merged

fix(files): hide move dialog action if destination has no CREATE permission#50177
Antreesy merged 2 commits into
masterfrom
fix/45982/hide-move-action

Conversation

@Antreesy

Copy link
Copy Markdown
Contributor

Summary

'MOVE' action requires both 'CREATE'+'DELETE' permission, therefore it should be hidden for non-writable directories. Currently action fails.

BeforeAfter
imageimage

Alternative: disable button (with the same logic)

Checklist

@AntreesyAntreesy added this to the Nextcloud 31 milestone Jan 14, 2025
@Antreesy
Antreesy requested a review from susnuxJanuary 14, 2025 13:33
@AntreesyAntreesy self-assigned this Jan 14, 2025
@Antreesy

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@susnux

Copy link
Copy Markdown
Contributor

Would it be possible to add a quick e2e test for this, so we do not run into regressions?

@skjnldsvskjnldsv mentioned this pull request Jan 14, 2025
@Antreesy

Copy link
Copy Markdown
ContributorAuthor

Would it be possible to add a quick e2e test for this, so we do not run into regressions?

Still can't make it run locally, and don't want to waste CI resources for blind attempts 😔

@Antreesy

Copy link
Copy Markdown
ContributorAuthor

/compile /

@skjnldsv

skjnldsv commented Jan 15, 2025

Copy link
Copy Markdown
Member

Still can't make it run locally

How so?
It works out of the box on multiple machines here 🤔

…ission
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesyforce-pushed the fix/45982/hide-move-action branch from ab6da71 to b06a876CompareJanuary 15, 2025 12:07
@Antreesy

Copy link
Copy Markdown
ContributorAuthor

/compile /

@Antreesy

Antreesy commented Jan 15, 2025

Copy link
Copy Markdown
ContributorAuthor

It works out of the box on multiple machines here

Need some tweaks to work on Windows + WSL2 + Docker + Cypress
normal dev setup has similar settings, but it's accessible due to proxy (ghcr.io/juliusknorr/nextcloud-dev-nginx:latest)

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv

Copy link
Copy Markdown
Member

Would it be possible to add a quick e2e test for this, so we do not run into regressions?

Please make sure tests are added as a followup @Antreesy 🙏

@Antreesy

Copy link
Copy Markdown
ContributorAuthor

/backport b06a876 to stable29

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Antreesy@susnux@skjnldsv@nextcloud-command