Skip to content

[stable29] fix(files): hide move dialog action if destination has no CREATE permission - #50238

Closed
backportbot[bot] wants to merge 4 commits into
stable29from
backport/50177/stable29
Closed

[stable29] fix(files): hide move dialog action if destination has no CREATE permission#50238
backportbot[bot] wants to merge 4 commits into
stable29from
backport/50177/stable29

Conversation

@backportbot

@backportbotbackportbotBot commented Jan 17, 2025

Copy link
Copy Markdown

Backport of #45982
Backport of #50177
Backport of #50206

Warning, This backport's changes differ from the original and might be incomplete ⚠️

@Antreesy

This comment was marked as outdated.

artongeand others added 2 commits January 21, 2025 12:45
…ission
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesyforce-pushed the backport/50177/stable29 branch from 6e78683 to cd31ec2CompareJanuary 21, 2025 11:46
@Antreesy

Copy link
Copy Markdown
Contributor

/compile /

Antreesyand others added 2 commits January 21, 2025 13:40
…ssion
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Antreesy
Antreesyforce-pushed the backport/50177/stable29 branch from 4b56a1c to 7653f96CompareJanuary 21, 2025 12:41
@Antreesy

Copy link
Copy Markdown
Contributor

CI Fail is due to #47185 backport is missing.
If there's no plan to backport it to stable29, shall we close this? @susnux@skjnldsv

Only missing bit is this one, though I don't know how much else will be broken:

exportconstcanMove=(nodes: Node[])=>{constminPermission=nodes.reduce((min,node)=>Math.min(min,node.permissions),Permission.ALL)returnBoolean(minPermission&Permission.DELETE)// Previously Permission.UPDATE}

@AltahrimAltahrim mentioned this pull request Feb 5, 2025
5 tasks
@susnux

Copy link
Copy Markdown
Contributor

If there's no plan to backport it to stable29, shall we close this?

makes sense

@susnuxsusnux closed this Feb 5, 2025
@susnux
susnux deleted the backport/50177/stable29 branch April 23, 2025 11:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Antreesy@susnux@skjnldsv@artonge@nextcloud-command